Issue metadata
Sign in to add a comment
|
Select menu with CSS transition flashes at interval of modified head element
Reported by
jtwalt...@gmail.com,
Apr 30 2016
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36 Example URL: http://codepen.io/jtwalters/pen/qZJzja Steps to reproduce the problem: 1. Click the select menu. 2. Watch the dropdown options flash. What is the expected behavior? No flash of select option dropdown. What went wrong? The dropdown options flash unexpectedly. Please see URL for reproduction. This is specifically when the head element is being modified during the CSS transition. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? Yes Chrome version: 50.0.2661.94 Channel: stable OS Version: OS X 10.11.4 Flash Version: Shockwave Flash 21.0 r0
,
May 11 2016
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06 commit 1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06 Author: tkent <tkent@chromium.org> Date: Wed May 11 17:13:12 2016 ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated crbug.com/608140 happens because animation on a SELECT element causes multiple didRecalcStyle calls, and ExternalPopupMenu::updateFromElement recreates a popup by a HEAD element change. This CL adds a |reason| argument to PopupMenu::updateFromElement. It is one of BySelectionChange, ByStyleChange, and ByDOMCHange. ExternalPopupMenu doesn't recreates its popup if the |reason| is ByStyleChange because ExternalPopupMenu doesn't support styling. BUG= 608140 Review-Url: https://codereview.chromium.org/1970653003 Cr-Commit-Position: refs/heads/master@{#392965} [modify] https://crrev.com/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp [modify] https://crrev.com/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06/third_party/WebKit/Source/core/html/HTMLSelectElement.h [modify] https://crrev.com/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06/third_party/WebKit/Source/core/loader/EmptyClients.cpp [modify] https://crrev.com/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06/third_party/WebKit/Source/platform/PopupMenu.h [modify] https://crrev.com/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06/third_party/WebKit/Source/web/ExternalPopupMenu.cpp [modify] https://crrev.com/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06/third_party/WebKit/Source/web/ExternalPopupMenu.h [modify] https://crrev.com/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06/third_party/WebKit/Source/web/PopupMenuImpl.cpp [modify] https://crrev.com/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06/third_party/WebKit/Source/web/PopupMenuImpl.h
,
May 12 2016
,
May 12 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 12 2016
Please merge your change to M51 branch 2704 before 5:00 PM PST, Monday (05/16/16), so we can take it in for next week LAST M51 beta release. Thank you.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b752c263dea6d780e5814be537f4a18732ac5409 commit b752c263dea6d780e5814be537f4a18732ac5409 Author: Kent Tamura <tkent@chromium.org> Date: Thu May 12 23:09:25 2016 Merge "ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated" to M51 crbug.com/608140 happens because animation on a SELECT element causes multiple didRecalcStyle calls, and ExternalPopupMenu::updateFromElement recreates a popup by a HEAD element change. This CL adds a |reason| argument to PopupMenu::updateFromElement. It is one of BySelectionChange, ByStyleChange, and ByDOMCHange. ExternalPopupMenu doesn't recreates its popup if the |reason| is ByStyleChange because ExternalPopupMenu doesn't support styling. BUG= 608140 Review-Url: https://codereview.chromium.org/1970653003 Cr-Commit-Position: refs/heads/master@{#392965} (cherry picked from commit 1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06) Review URL: https://codereview.chromium.org/1972243003 . Cr-Commit-Position: refs/branch-heads/2704@{#529} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/b752c263dea6d780e5814be537f4a18732ac5409/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp [modify] https://crrev.com/b752c263dea6d780e5814be537f4a18732ac5409/third_party/WebKit/Source/core/html/HTMLSelectElement.h [modify] https://crrev.com/b752c263dea6d780e5814be537f4a18732ac5409/third_party/WebKit/Source/core/loader/EmptyClients.cpp [modify] https://crrev.com/b752c263dea6d780e5814be537f4a18732ac5409/third_party/WebKit/Source/platform/PopupMenu.h [modify] https://crrev.com/b752c263dea6d780e5814be537f4a18732ac5409/third_party/WebKit/Source/web/ExternalPopupMenu.cpp [modify] https://crrev.com/b752c263dea6d780e5814be537f4a18732ac5409/third_party/WebKit/Source/web/ExternalPopupMenu.h [modify] https://crrev.com/b752c263dea6d780e5814be537f4a18732ac5409/third_party/WebKit/Source/web/PopupMenuImpl.cpp [modify] https://crrev.com/b752c263dea6d780e5814be537f4a18732ac5409/third_party/WebKit/Source/web/PopupMenuImpl.h
,
May 18 2016
Tested the issue on Mac 10.11.4 using chrome version 51.0.2704.54.Not observed any flash on selecting drop down values.Please find the attached screen cast for the same. Adding TE-Verified label. Thanks,
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 Deleted