New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug-Regression



Sign in to add a comment

console.log trigger promise callbacks

Project Member Reported by kozyatinskiy@chromium.org, Apr 30 2016

Issue description

Promise.resolve().then(()=>console.log(239));
console.log(42);
console.log(43);

Actual:
42
239
43

Expected:
42
43
239
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a03cc9b51b4a88cffab3ffcfb4fc591606463d39

commit a03cc9b51b4a88cffab3ffcfb4fc591606463d39
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Sat Apr 30 21:43:59 2016

[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG= 595206 , 608138 

Review-Url: https://codereview.chromium.org/1932343002
Cr-Commit-Position: refs/heads/master@{#390863}

[modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script-expected.txt
[add] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.html
[add] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks-expected.txt
[add] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks.html
[modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters-expected.txt
[modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
[modify] https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Labels: -Pri-1 Merge-Request-51 Pri-0

Comment 3 by tin...@google.com, May 1 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cf1b1896858bae98f8f1725f36fbf9056bc341e

commit 8cf1b1896858bae98f8f1725f36fbf9056bc341e
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon May 02 06:24:28 2016

[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG= 595206 , 608138 

Review-Url: https://codereview.chromium.org/1932343002
Cr-Commit-Position: refs/heads/master@{#390863}
(cherry picked from commit a03cc9b51b4a88cffab3ffcfb4fc591606463d39)

Review URL: https://codereview.chromium.org/1940783002 .

Cr-Commit-Position: refs/branch-heads/2704@{#327}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script-expected.txt
[add] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.html
[add] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks-expected.txt
[add] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks.html
[modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters-expected.txt
[modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
[modify] https://crrev.com/8cf1b1896858bae98f8f1725f36fbf9056bc341e/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Status: Fixed (was: Assigned)
Labels: TE-Verified-M51 TE-Verified-51.0.2704.36
Tested the issue on Windows 7, Mac 10.10.5, Ubuntu 14.04 using 51.0.2704.36.Observed the console result as below:
42
43
239
Please find attached screenshot.

Marking it as TE-Verified.
608138.png
115 KB View Download

Sign in to add a comment