New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608134 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Subpage page width doesn't respond to window resizing

Project Member Reported by bettes@chromium.org, Apr 30 2016

Issue description

I thought I had filed this already so apologies if this is a duplicate. 

****

When window is resized, the subpage doesn't respond. Ideally, the subpage responds just as the main cards do, so the transition to and from subpage is smoother. 
 
movie.mov
12.9 MB Download

Comment 1 by dbeam@chromium.org, May 2 2016

Cc: dpa...@chromium.org
I briefly looked into this, and it seems that <paper-material> usage at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/settings/settings_page/settings_section.html&l=11 is causing the problem. Somewhere (did not find exactly where), the width of the <paper-material> element is set by JS, and then it does not get updated as the page is resized.

This bug does not seem related to previous similar  crbug.com/600887  which was caused by neon-animation.
Cc: dschuyler@chromium.org tommycli@chromium.org
Yes, I'll look into fixing this.
Labels: Hotlist-MD-Settings-Structure
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d220fa3bf6fad9443d84e4e53ddded5597f96e

commit d9d220fa3bf6fad9443d84e4e53ddded5597f96e
Author: michaelpg <michaelpg@chromium.org>
Date: Tue Jun 07 03:43:53 2016

MD Settings: Responsive sub-page width

The width only needs to be set explicitly during animations, when the card
is position: fixed.

BUG= 608134 
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2041073002
Cr-Commit-Position: refs/heads/master@{#398217}

[modify] https://crrev.com/d9d220fa3bf6fad9443d84e4e53ddded5597f96e/chrome/browser/resources/settings/settings_page/main_page_behavior.js

Status: Fixed (was: Started)

Sign in to add a comment