New issue
Advanced search Search tips

Issue 608131 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Privacy/Security] Sub-page padding incorrect

Project Member Reported by bettes@chromium.org, Apr 30 2016

Issue description

Expected:
All icons and text should align to the same vertical keyline

Actual:
Icons are too far left, text is too far right

Spec:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_structure-subpage.png%3Fz=width&c=show


 
Screen Shot 2016-04-29 at 6.46.44 PM.png
25.9 KB View Download

Comment 1 by bettes@chromium.org, Apr 30 2016

This applies to all sub-sub-pages as well: Cookies, Location, Camera, etc.

Comment 2 by bettes@chromium.org, Apr 30 2016

Summary: [Privacy/Security] Sub-page padding incorrect (was: Sub-page padding incorrect)
I've made some adjustments to the columns, see screenshots.
2. site-settings-category-all.png
56.9 KB View Download
3. site-settings-category-notifications.png
48.8 KB View Download
4. site-settings-details.png
48.1 KB View Download
1. site-settings-page.png
53.8 KB View Download
This is from this CL:
https://codereview.chromium.org/1947033003

Let me know if this is OK and I'll send it for review.

Comment 7 by bettes@chromium.org, May 11 2016

Status: Fixed (was: Assigned)
LGTM

Sign in to add a comment