New issue
Advanced search Search tips

Issue 608128 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 582622



Sign in to add a comment

"Bundled" Component Updater Components Support

Project Member Reported by waff...@chromium.org, Apr 30 2016

Issue description

We need a generic way to support components that can be bundled with the initial install of Chrome, such as Flash (or soon Widevine). Diff updates and so forth should work transparently for such components.
 

Comment 1 by xhw...@chromium.org, Apr 30 2016

Blocking: 582622
Labels: M-52
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb4f42ca4ef394517e4f94a231ae531f331d4ca8

commit cb4f42ca4ef394517e4f94a231ae531f331d4ca8
Author: waffles <waffles@chromium.org>
Date: Mon May 16 22:50:32 2016

DefaultComponentInstaller support for bundled components.

DefaultComponentInstaller will now pick up component implementations from the plugins directory. It expects the component to have a folder in the plugins directory with the same name as we would store in USER_DATA_DIR. Unlike USER_DATA_DIR, this folder should not contain a set of versioned folders, but the unpacked contents of the CRX itself.

As a consequence of this, the installation directory of a component cannot be determined purely by PathService, so I have gone ahead and removed the relevant PathService entries.

BUG= 608128 

Review-Url: https://codereview.chromium.org/1937683002
Cr-Commit-Position: refs/heads/master@{#393961}

[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/caps_installer_win.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/cld_component_installer.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/cld_component_installer.h
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/cld_component_installer_unittest.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/ev_whitelist_component_installer.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/ev_whitelist_component_installer.h
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/origin_trials_component_installer.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/origin_trials_component_installer.h
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/sth_set_component_installer.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/sth_set_component_installer.h
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/common/chrome_paths.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/common/chrome_paths.h
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/chrome/test/base/chrome_unit_test_suite.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/components/component_updater/component_updater_paths.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/components/component_updater/component_updater_paths.h
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/components/component_updater/default_component_installer.cc
[modify] https://crrev.com/cb4f42ca4ef394517e4f94a231ae531f331d4ca8/components/component_updater/default_component_installer.h

Comment 3 by xhw...@chromium.org, May 26 2016

Is this fixed now?
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-53 M-52
Status: Fixed (was: Started)
Whoops, this was fixed in 52.

Sign in to add a comment