The mojo:user service fails to connect in the context of content browser tests |
||
Issue descriptionThe mojo:user service fails to connect in the context of content browser tests. To repro see the snapshot labled "4ken" https://codereview.chromium.org/1923673002/#ps60001 It alters the test to never signal completion so connection service establishment is allowed to fully play out. Connect(user_service::kUserServiceName) fails but OnUserServiceConnectionError is never called.
,
May 2 2016
Some more info about the bug. When it fails with "Failed to load app library" in the log, a closure attached via AddConnectionCompletedClosure gets called which is good, but Connection::GetResult returns SUCCEEDED which seems wrong.
,
May 2 2016
When the bug is fixed, a couple of disabled content browser tests can be enbaled: MojoDOMStorageBrowserTest, SanityCheck and SanityCheckIncognito
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02dd0a2c25d9ace3cac32ea5cc9e5c1c45371d22 commit 02dd0a2c25d9ace3cac32ea5cc9e5c1c45371d22 Author: rockot <rockot@chromium.org> Date: Wed May 04 14:07:14 2016 Add GYP support for packaged manifests Also hooks up mojo:user to exe:content_browser's manifest in GYP builds. BUG= 608121 Review-Url: https://codereview.chromium.org/1951673002 Cr-Commit-Position: refs/heads/master@{#391500} [modify] https://crrev.com/02dd0a2c25d9ace3cac32ea5cc9e5c1c45371d22/content/content.gyp [modify] https://crrev.com/02dd0a2c25d9ace3cac32ea5cc9e5c1c45371d22/mojo/public/mojo_application_manifest.gypi
,
May 4 2016
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6936a1c58d788c0f6ff847a139c0ff3918aa65b4 commit 6936a1c58d788c0f6ff847a139c0ff3918aa65b4 Author: michaeln <michaeln@chromium.org> Date: Mon May 09 19:25:53 2016 Enable the MojoDOMSTorageBrowserTests on most platforms now that crbug/608121 is fixed. Still disabled on osx until 609632 is figured out. BUG= 586194 , 609632 , 608121 TBR=jam Review-Url: https://codereview.chromium.org/1947213002 Cr-Commit-Position: refs/heads/master@{#392393} [modify] https://crrev.com/6936a1c58d788c0f6ff847a139c0ff3918aa65b4/content/browser/dom_storage/dom_storage_browsertest.cc [modify] https://crrev.com/6936a1c58d788c0f6ff847a139c0ff3918aa65b4/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/6936a1c58d788c0f6ff847a139c0ff3918aa65b4/services/shell/shell.cc |
||
►
Sign in to add a comment |
||
Comment 1 by michaeln@chromium.org
, Apr 30 2016But if you invoke a synchronous round trip, the error handler does get called. Adding these two lines to sanity_check.js do that. function sanityCheck(storage) { storage["preload"] = "done"; checkEqual("done", storage["preload"], "whoa");