New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608115 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 631891
issue 632382
issue 637470

Blocking:
issue 537359
issue 626151



Sign in to add a comment

MD Settings router enhancements

Project Member Reported by dpa...@chromium.org, Apr 30 2016

Issue description

A linear search is performed at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/settings/settings_page/settings_router.js&l=42-51 to find which page to display based on the current URL.

This does not seem very scale-able as we start exposing more URLs that navigate to specific sub sections of the settings. Currently there are 46 routes.

A possible alternative would be instead of using an array to hold all possible routes, to use a tree data structure which represents the page-subpage-subsection structure. The page to display can be found by simply navigating the tree based on the current URL.
 
Status: Available (was: Untriaged)
Labels: Hotlist-MD-Settings-General

Comment 3 by dpa...@chromium.org, Jun 28 2016

Cc: dbeam@chromium.org tommycli@chromium.org
Owner: tommycli@chromium.org
I'm all about linear searches. Thx for bug.

Comment 5 by dbeam@chromium.org, Jun 28 2016

Status: Assigned (was: Available)
I really don't care about the efficiency of looking through 40 extra property lookups unless you can prove it's slow.  But we need to support dialogs in URLs (i.e. /clearBrowserData) so I'll re-purpose your bug.

Comment 6 by dbeam@chromium.org, Jun 28 2016

Summary: MD Settings router enhancements (was: MD Settings router performs unnecessary linear search to find which page to display.)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dbad9e386a6547eff369969b657f4ef3117a859

commit 4dbad9e386a6547eff369969b657f4ef3117a859
Author: dbeam <dbeam@chromium.org>
Date: Fri Jul 01 23:59:42 2016

MD Settings: add a concept of "Canonical routes", which include URLs

R=tommycli@chromium.org
BUG= 608115 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2115133002
Cr-Commit-Position: refs/heads/master@{#403568}

[modify] https://crrev.com/4dbad9e386a6547eff369969b657f4ef3117a859/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/4dbad9e386a6547eff369969b657f4ef3117a859/chrome/test/data/webui/settings/router_tests.js

Status: Started (was: Assigned)
Blocking: 626151
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8acb9d5f2f71c3df8e64b13ee321a9d194e89785

commit 8acb9d5f2f71c3df8e64b13ee321a9d194e89785
Author: tommycli <tommycli@chromium.org>
Date: Sat Jul 16 19:26:21 2016

Settings Router Refactor: Migrate canonical route list to new-style.

This links the router element to the new-style route list.

BUG= 608115 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2153113003
Cr-Commit-Position: refs/heads/master@{#405947}

[modify] https://crrev.com/8acb9d5f2f71c3df8e64b13ee321a9d194e89785/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/8acb9d5f2f71c3df8e64b13ee321a9d194e89785/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
[modify] https://crrev.com/8acb9d5f2f71c3df8e64b13ee321a9d194e89785/chrome/browser/resources/settings/settings_page/settings_router.html
[modify] https://crrev.com/8acb9d5f2f71c3df8e64b13ee321a9d194e89785/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/8acb9d5f2f71c3df8e64b13ee321a9d194e89785/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/8acb9d5f2f71c3df8e64b13ee321a9d194e89785/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/8acb9d5f2f71c3df8e64b13ee321a9d194e89785/chrome/test/data/webui/settings/route_tests.js
[delete] https://crrev.com/c2261d558540e802ce57e542366549d2f9c87e41/chrome/test/data/webui/settings/router_tests.js

Blocking: 537359
Blocking: 630505
Blockedon: 631891
Blockedon: 632382
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a9687b5f484dd599d094f14d426b5d4c166cc26

commit 8a9687b5f484dd599d094f14d426b5d4c166cc26
Author: tommycli <tommycli@chromium.org>
Date: Thu Jul 28 20:37:21 2016

Settings Router Refactor: Migrate to settings.Route.navigateTo calls.

BUG= 608115 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2156413002
Cr-Commit-Position: refs/heads/master@{#408466}

[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/about_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/advanced_page/advanced_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/device_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/device_page/keyboard.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_authenticate.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_authenticate.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_password_detect_behavior.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_password_detect_behavior.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_routing_behavior.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_routing_behavior.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/search_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/search_page/search_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_page/settings_animated_pages.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/site_settings/site_settings_behavior.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/site_settings_page/compiled_resources2.gyp
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/8a9687b5f484dd599d094f14d426b5d4c166cc26/chrome/test/data/webui/settings/site_list_tests.js

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97e96fefb27bce1fc57e0afc563a6a48ab6f8338

commit 97e96fefb27bce1fc57e0afc563a6a48ab6f8338
Author: tommycli <tommycli@chromium.org>
Date: Thu Jul 28 21:29:17 2016

Settings Router Refactor: Fix Closure compile issue from merge conflict.

Device page added a new navigation at the same time as the mega
router navigateTo patch. This fixes the Closure compile issue that
resulted from that collision.

BUG= 608115 
TBR=jdufault@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true

Review-Url: https://codereview.chromium.org/2189533005
Cr-Commit-Position: refs/heads/master@{#408482}

[modify] https://crrev.com/97e96fefb27bce1fc57e0afc563a6a48ab6f8338/chrome/browser/resources/settings/device_page/device_page.js

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e

commit a8671b2f203fbf69b9feb2014664df0d6fdf5b1e
Author: tommycli <tommycli@chromium.org>
Date: Fri Jul 29 20:59:42 2016

Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes).

This mostly cleans up some routing code in Quick Unlock. It also has a few small fixes in People.

BUG= 608115 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2154213008
Cr-Commit-Position: refs/heads/master@{#408736}

[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/quick_unlock_authenticate.html
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/quick_unlock_authenticate.js
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.html
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/quick_unlock_password_detect_behavior.js
[delete] https://crrev.com/2d7256e0b39ae12ec3e2ec38da36857f8a0854e1/chrome/browser/resources/settings/people_page/quick_unlock_routing_behavior.html
[delete] https://crrev.com/2d7256e0b39ae12ec3e2ec38da36857f8a0854e1/chrome/browser/resources/settings/people_page/quick_unlock_routing_behavior.js
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.html
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e/chrome/test/data/webui/settings/people_page_sync_page_test.js

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa9c34d72c27a54b09d1790fa425ea2f25cc9716

commit aa9c34d72c27a54b09d1790fa425ea2f25cc9716
Author: tommycli <tommycli@chromium.org>
Date: Sat Jul 30 00:11:23 2016

Settings Router Refactor: Remove route.page legacy property.

This property is not used that much, and can be removed.

BUG= 608115 ,  628502 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2184893002
Cr-Commit-Position: refs/heads/master@{#408815}

[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/advanced_page/advanced_page.html
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/test/data/webui/settings/settings_menu_test.js

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/431600500292c1394cee9c76746395bf525bd1ec

commit 431600500292c1394cee9c76746395bf525bd1ec
Author: tommycli <tommycli@chromium.org>
Date: Mon Aug 01 20:42:22 2016

Setting Router Refactor: Implement RouteObserverBehavior.

This also removes most of the contents of settings-router. It still
exists for now to propagate the property update, but will be removed
once everything uses RouteObserverBehavior.

BUG= 608115 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2193333002
Cr-Commit-Position: refs/heads/master@{#409047}

[modify] https://crrev.com/431600500292c1394cee9c76746395bf525bd1ec/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/431600500292c1394cee9c76746395bf525bd1ec/chrome/browser/resources/settings/settings_page/settings_router.js

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/431600500292c1394cee9c76746395bf525bd1ec

commit 431600500292c1394cee9c76746395bf525bd1ec
Author: tommycli <tommycli@chromium.org>
Date: Mon Aug 01 20:42:22 2016

Setting Router Refactor: Implement RouteObserverBehavior.

This also removes most of the contents of settings-router. It still
exists for now to propagate the property update, but will be removed
once everything uses RouteObserverBehavior.

BUG= 608115 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2193333002
Cr-Commit-Position: refs/heads/master@{#409047}

[modify] https://crrev.com/431600500292c1394cee9c76746395bf525bd1ec/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/431600500292c1394cee9c76746395bf525bd1ec/chrome/browser/resources/settings/settings_page/settings_router.js

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c7966816ea0d4304c1caba897668ec12964e7eb

commit 6c7966816ea0d4304c1caba897668ec12964e7eb
Author: tommycli <tommycli@chromium.org>
Date: Tue Aug 02 18:27:48 2016

Settings Router Refactor: Improve chrome://md-settings/foobar behavior.

Correctly reset the URL path to '/' when the user directly navigates
to a non-existent URL.

BUG= 608115 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2200013002
Cr-Commit-Position: refs/heads/master@{#409252}

[modify] https://crrev.com/6c7966816ea0d4304c1caba897668ec12964e7eb/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/6c7966816ea0d4304c1caba897668ec12964e7eb/chrome/test/data/webui/settings/cr_settings_browsertest.js

Blockedon: 637470
Blocking: -630505
Status: Fixed (was: Started)

Sign in to add a comment