DevTools: [regression] security panel throws exceptions and resets upon navigation. |
||||
Issue description
[13488:13488:0429/170451:ERROR:CONSOLE(522)] "TypeError: Cannot read property 'url' of undefined TypeError: Cannot read property 'url' of undefined
at Object._onMainFrameNavigated (chrome-devtools://devtools/bundled/security/SecurityPanel.js:280:79)
at Object.dispatchEventToListeners (chrome-devtools://devtools/bundled/common/Object.js:110:35)
at Object._frameNavigated (chrome-devtools://devtools/bundled/sdk/ResourceTreeModel.js:287:18)
at Object.frameNavigated (chrome-devtools://devtools/bundled/sdk/ResourceTreeModel.js:817:33)
at Object.dispatch (chrome-devtools://devtools/bundled/sdk/InspectorBackend.js:718:40)
at Object.dispatch (chrome-devtools://devtools/bundled/sdk/InspectorBackend.js:359:43)
at Object._dispatchMessage (chrome-devtools://devtools/bundled/sdk/ServiceWorkerManager.js:278:32)
at Object.dispatchMessage (chrome-devtools://devtools/bundled/sdk/ServiceWorkerManager.js:536:23)
at Object.dispatch (chrome-devtools://devtools/bundled/sdk/InspectorBackend.js:718:40)
at Object.dispatch (chrome-devtools://devtools/bundled/sdk/InspectorBackend.js:359:43)"
,
Apr 30 2016
If you look at the code where it crashes, you can see how you check request for being null after using it.
,
Apr 30 2016
The specific details to repro are: open any site, security panel and reload the page...
,
Apr 30 2016
123456
,
May 2 2016
This bug has been marked as M51 Beta blocker. And we're cutting M51 Beta candidate tomorrow. Please try to resolve this ASAP.Thank you.
,
May 2 2016
I cannot reproduce with a fresh build of the latest M51 tag according to https://omahaproxy.appspot.com/ . pfeldman@, are there any additional repro conditions?
,
May 2 2016
Turns out to be caused by service workers. pfeldman@ helped me author a fix at https://codereview.chromium.org/1938183003
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9bfaecea4885f2dd2ba60796e998f1fb5e5d3e7 commit c9bfaecea4885f2dd2ba60796e998f1fb5e5d3e7 Author: lgarron <lgarron@chromium.org> Date: Tue May 03 01:26:12 2016 Security panel: add listeners only to the added target. This prevents the Security panel from getting MainFrameNavigated events from service workers. BUG= 608113 TEST=1. Open the native new tab page. 2. Open the DevTools Security panel. 3. Refresh 4. Wait a few seconds The sidebar of the Security panel should show at least three sections (Main Origin, Non-Secure Origins, Secure Origins), and those sections should *not disappear*. Review-Url: https://codereview.chromium.org/1938183003 Cr-Commit-Position: refs/heads/master@{#391142} [modify] https://crrev.com/c9bfaecea4885f2dd2ba60796e998f1fb5e5d3e7/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
,
May 3 2016
Fixed in M-52, will ask for merge to M-51 once it's baked on Canary.
,
May 3 2016
Fix is not critical, will be merged later this week. It is ok to push Beta tomorrow without this fix. |
||||
►
Sign in to add a comment |
||||
Comment 1 by lgar...@chromium.org
, Apr 30 2016