New issue
Advanced search Search tips

Issue 608111 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

UNINITIALIZED READ in blink platform test

Project Member Reported by osh...@chromium.org, Apr 29 2016

Issue description

Started on:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/7141

The following may be a culprit:
https://chromium.googlesource.com/chromium/src/+/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8

kulshin@, can you look into this?

Or could be this skia roll:
https://chromium.googlesource.com/chromium/src/+/57be8859cd5d5e68a145b73ded0b2ba1b89fd980


UNINITIALIZED READ: reading 0x0082f120-0x0082f124 4 byte(s)
# 0 DWrite.dll!DWriteCreateFactory                                            +0xaf703  (0x67d8b5bf <DWrite.dll+0xbb5bf>)
# 1 skia.dll!SkDWriteFontFileStreamWrapper::GetFileSize                        [third_party\skia\src\utils\win\skdwritefontfilestream.cpp:225]
# 2 skia.dll!SkScalerContext_DW::generateAdvance                               [third_party\skia\src\ports\skscalercontext_win_dw.cpp:357]
# 3 skia.dll!SkGlyphCache::allocateNewGlyph                                    [third_party\skia\src\core\skglyphcache.cpp:188]
# 4 skia.dll!SkGlyphCache::lookupByPackedGlyphID                               [third_party\skia\src\core\skglyphcache.cpp:168]
# 5 skia.dll!SkGlyphCache::getGlyphIDAdvance                                   [third_party\skia\src\core\skglyphcache.cpp:122]
# 6 skia.dll!sk_getAdvance_glyph_next                                          [third_party\skia\src\core\skpaint.cpp:659]
# 7 skia.dll!SkPaint::measure_text                                             [third_party\skia\src\core\skpaint.cpp:789]
# 8 skia.dll!SkPaint::measureText                                              [third_party\skia\src\core\skpaint.cpp:844]
# 9 blink_platform.dll!blink::SimpleFontData::platformWidthForGlyph            [third_party\webkit\source\platform\fonts\simplefontdata.cpp:422]
#10 blink_platform.dll!blink::SimpleFontData::platformInit                     [third_party\webkit\source\platform\fonts\simplefontdata.cpp:238]
#11 blink_platform.dll!blink::SimpleFontData::SimpleFontData                   [third_party\webkit\source\platform\fonts\simplefontdata.cpp:66]
#12 blink_platform.dll!blink::SimpleFontData::create                           [third_party\webkit\source\platform\fonts\simplefontdata.h:53]
#13 blink::testing::`anonymous namespace'::TestFontSelector::getFontData       [third_party\webkit\source\platform\testing\fonttesthelpers.cpp:41]
#14 blink_platform.dll!blink::FontFallbackList::getFontData                    [third_party\webkit\source\platform\fonts\fontfallbacklist.cpp:164]
#15 blink_platform.dll!blink::FontFallbackList::fontDataAt                     [third_party\webkit\source\platform\fonts\fontfallbacklist.cpp:223]
#16 blink_platform.dll!blink::FontFallbackList::determinePrimarySimpleFontData [third_party\webkit\source\platform\fonts\fontfallbacklist.cpp:111]
#17 blink_platform.dll!blink::Font::primaryFont                                [third_party\webkit\source\platform\fonts\font.h:175]
#18 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
Note: @0:00:31.559 in thread 1220
Note: instruction: fld    0xffffff38(%ebp) -> %st0
Suppression (error hash=#0E4743F42A32926E#):
For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the-
{
UNINITIALIZED READ
name=<insert_a_suppression_name_here>
DWrite.dll!DWriteCreateFactory
skia.dll!SkDWriteFontFileStreamWrapper::GetFileSize
skia.dll!SkScalerContext_DW::generateAdvance
skia.dll!SkGlyphCache::allocateNewGlyph
skia.dll!SkGlyphCache::lookupByPackedGlyphID
skia.dll!SkGlyphCache::getGlyphIDAdvance
skia.dll!sk_getAdvance_glyph_next
skia.dll!SkPaint::measure_text
skia.dll!SkPaint::measureText
blink_platform.dll!blink::SimpleFontData::platformWidthForGlyph
blink_platform.dll!blink::SimpleFontData::platformInit
blink_platform.dll!blink::SimpleFontData::SimpleFontData
blink_platform.dll!blink::SimpleFontData::create
*!blink::testing::`anonymous namespace'::TestFontSelector::getFontData
blink_platform.dll!blink::FontFallbackList::getFontData
blink_platform.dll!blink::FontFallbackList::fontDataAt
blink_platform.dll!blink::FontFallbackList::determinePrimarySimpleFontData
blink_platform.dll!blink::Font::primaryFont
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93ac305579eaa690f7233542523f2eaa6f1fb8a8

commit 93ac305579eaa690f7233542523f2eaa6f1fb8a8
Author: oshima <oshima@chromium.org>
Date: Sat Apr 30 00:43:23 2016

Suppress UNINITIALIZED READ in blink platform test

BUG=608111
TBR=kulshin@chromium.org,

Review-Url: https://codereview.chromium.org/1940663002
Cr-Commit-Position: refs/heads/master@{#390822}

[modify] https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8/tools/valgrind/drmemory/suppressions.txt

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf69f6e38876d892e8b6830117320420ce8274ce

commit bf69f6e38876d892e8b6830117320420ce8274ce
Author: kulshin <kulshin@chromium.org>
Date: Wed May 25 20:16:38 2016

Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ )

Reason for revert:
Removing the suppression to determine if this is still a
problem. I'm unable to reproduce the error locally.
http://chromium-build-logs.appspot.com/suppression_query
also suggests this suppression is no longer needed.

Original issue's description:
> Suppress UNINITIALIZED READ in blink platform test
>
> BUG=608111
> TBR=kulshin@chromium.org,
>
> Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8
> Cr-Commit-Position: refs/heads/master@{#390822}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=608111

Review-Url: https://codereview.chromium.org/2002323002
Cr-Commit-Position: refs/heads/master@{#395975}

[modify] https://crrev.com/bf69f6e38876d892e8b6830117320420ce8274ce/tools/valgrind/drmemory/suppressions.txt

Project Member

Comment 4 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7545bb204f767f0c076377bfea29972623efcfb2

commit 7545bb204f767f0c076377bfea29972623efcfb2
Author: thestig <thestig@chromium.org>
Date: Tue May 31 02:24:23 2016

Reland of Suppress UNINITIALIZED READ in blink platform test (patchset #2 id:40001 of https://codereview.chromium.org/2002323002/ )

Reason for revert:
Still a problem.

Original issue's description:
> Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ )
>
> Reason for revert:
> Removing the suppression to determine if this is still a
> problem. I'm unable to reproduce the error locally.
> http://chromium-build-logs.appspot.com/suppression_query
> also suggests this suppression is no longer needed.
>
> Original issue's description:
> > Suppress UNINITIALIZED READ in blink platform test
> >
> > BUG=608111
> > TBR=kulshin@chromium.org,
> >
> > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8
> > Cr-Commit-Position: refs/heads/master@{#390822}
>
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=608111
>
> Committed: https://crrev.com/bf69f6e38876d892e8b6830117320420ce8274ce
> Cr-Commit-Position: refs/heads/master@{#395975}

TBR=oshima@chromium.org,kulshin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=608111

Review-Url: https://codereview.chromium.org/2020133002
Cr-Commit-Position: refs/heads/master@{#396767}

[modify] https://crrev.com/7545bb204f767f0c076377bfea29972623efcfb2/tools/valgrind/drmemory/suppressions.txt

Status: Assigned (was: Fixed)
Owner: ----
Status: Available (was: Assigned)
I've been unable to repro. Since the callstack indicates the error is in Skia code, could a Skia dev take a look?
Components: Internals>Skia
Status: Untriaged (was: Available)

Comment 8 Deleted

Sign in to add a comment