All rules locations are shown as *.CSS. They should show *.SCSS if they actually come from SCSS. This happens as rule location is generated from the first matched selector location and because we don't account for selectors in LiveSASS.
Good
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a14461fedcb35dda8aed002ffa971479d15892b9 commit a14461fedcb35dda8aed002ffa971479d15892b9 Author: lushnikov <lushnikov@chromium.org> Date: Tue May 03 23:00:07 2016 DevTools: [SASS] parse SCSS rules and their selectors. This patch teaches SCSS parser to extract rules array. For example, given the following SCSS: $color: red; .message { border: 1px solid black; .title { color: #333; } } The SCSS parser will extract three rules, with all top-level declarations contained by the first rule without any selectors. { $color: red; } .message { border: 1px solid black; } .title { color: #333; } BUG= 608097 R=pfeldman Review-Url: https://codereview.chromium.org/1938313002 Cr-Commit-Position: refs/heads/master@{#391383} [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-1-expected.txt [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-2-expected.txt [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-3-expected.txt [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-4-expected.txt [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-5-expected.txt [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6-expected.txt [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-7-expected.txt [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js [modify] https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09f3f7b5ab511baa8f4e594736251b2e25ef107a commit 09f3f7b5ab511baa8f4e594736251b2e25ef107a Author: lushnikov <lushnikov@chromium.org> Date: Wed May 04 02:14:15 2016 DevTools: [SASS] start parsing CSS with SCSS parser As CSS is a subset of SCSS, we can just parse CSS with the SCSS parser. BUG= 608097 R=pfeldman Review-Url: https://codereview.chromium.org/1941283002 Cr-Commit-Position: refs/heads/master@{#391414} [modify] https://crrev.com/09f3f7b5ab511baa8f4e594736251b2e25ef107a/third_party/WebKit/LayoutTests/inspector/sass/sass-test.js [modify] https://crrev.com/09f3f7b5ab511baa8f4e594736251b2e25ef107a/third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-3-expected.txt [modify] https://crrev.com/09f3f7b5ab511baa8f4e594736251b2e25ef107a/third_party/WebKit/LayoutTests/inspector/sass/test-ast-editing-1-expected.txt [modify] https://crrev.com/09f3f7b5ab511baa8f4e594736251b2e25ef107a/third_party/WebKit/Source/devtools/front_end/sass/ASTService.js [modify] https://crrev.com/09f3f7b5ab511baa8f4e594736251b2e25ef107a/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e98d06e71e63bebefcc8b5075895680925afc52 commit 7e98d06e71e63bebefcc8b5075895680925afc52 Author: lushnikov <lushnikov@chromium.org> Date: Wed May 04 04:28:50 2016 DevTools: [SASS] extract exact property name and value ranges The patch starts extracting exact property name and value ranges, which makes it possible to link sourceMap entries based on the text node start position. BUG= 608097 R=pfeldman Review-Url: https://codereview.chromium.org/1944593002 Cr-Commit-Position: refs/heads/master@{#391443} [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-1-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-2-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-3-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-editing-1-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-1-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-2-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-3-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-4-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-5-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-7-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/LayoutTests/inspector/sass/test-edit-insert-property-expected.txt [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js [modify] https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52/third_party/WebKit/Source/devtools/front_end/sass/SASSSourceMapFactory.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080 commit 16c34c8a98f1ea2e83bed8ab130ec12bcae9e080 Author: lushnikov <lushnikov@chromium.org> Date: Wed May 04 08:19:45 2016 DevTools: [SASS] CSSRule supports selector text nodes This patch adds selectors as a text nodes into AST tree. As a result, this patch starts displaying rule locations as *.scss in Styles Sidebar Pane. BUG= 608097 R=pfeldman Review-Url: https://codereview.chromium.org/1935403002 Cr-Commit-Position: refs/heads/master@{#391460} [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/sass-test.js [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-1-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-2-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-3-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-1-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-2-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-3-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-4-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-5-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-7-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-mapping-good-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/LayoutTests/inspector/sass/test-mapping-many-scss-expected.txt [modify] https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
Comment 1 by lushnikov@chromium.org
, Apr 29 2016