New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608091 link

Starred by 4 users
Status: Fixed
Owner:
qin...@chromium.org
Closed: May 2016
Cc:
█ sidv@chromium.org
█ rolfe@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Media downloads from standalone media page show indefinitely

Project Member Reported by k...@chromium.org, Apr 29 2016 
To reproduce:
1) Use Chrome Canary/Dev
2) Go to a standalone video file, e.g. http://video.webmfiles.org/big-buck-bunny_trailer.webm
3) Long-press the toolbar and tap "Save video"

Expected: The download notification goes away once download is complete

Observed: The download notification doesn't show progress (going indefinitely) and does not go away (or change) once download is complete
download_notification_bug_2.mp4
6.4 MB Download

Comment 1 by widarton...@gmail.com, May 1 2016

download_notification_bug_2.mp4
6.4 MB Download
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0e99eea9df4ba893cb307960f3bc7194e469bd7

commit f0e99eea9df4ba893cb307960f3bc7194e469bd7
Author: qinmin <qinmin@chromium.org>
Date: Mon May 02 17:07:22 2016

Fix a bug that progress notification can linger after download completes

If the size of the download is unknwon, percentage completed is
always -1.
The current code doesn't add the download into SharedPreference in that case.
As a result, the SharedPref will not be found when download completes.
This causes notifyDownloadSuccess() to early return.
This CL fix the issue by always adding the download entry into the
sharedprefs.

BUG= 608091 

Review-Url: https://codereview.chromium.org/1939593002
Cr-Commit-Position: refs/heads/master@{#390970}

[modify] https://crrev.com/f0e99eea9df4ba893cb307960f3bc7194e469bd7/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Comment 3 by qin...@chromium.org, May 2 2016

Labels: Merge-Request-51 M-51
Status: Started (was: Untriaged)

Comment 4 by amineer@chromium.org, May 2 2016

Labels: OS-Android

Comment 5 by tin...@google.com, May 2 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 6 by bugdroid1@chromium.org, May 2 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab9b8915bbd8eb8d21c24de8a4929fd020b93c8f

commit ab9b8915bbd8eb8d21c24de8a4929fd020b93c8f
Author: Min Qin <qinmin@chromium.org>
Date: Mon May 02 21:01:18 2016

Fix a bug that progress notification can linger after download completes

If the size of the download is unknwon, percentage completed is
always -1.
The current code doesn't add the download into SharedPreference in that case.
As a result, the SharedPref will not be found when download completes.
This causes notifyDownloadSuccess() to early return.
This CL fix the issue by always adding the download entry into the
sharedprefs.

TBR=tedchoc@chromium.org
BUG= 608091 

Review-Url: https://codereview.chromium.org/1939593002
Cr-Commit-Position: refs/heads/master@{#390970}
(cherry picked from commit f0e99eea9df4ba893cb307960f3bc7194e469bd7)

Review URL: https://codereview.chromium.org/1938173002 .

Cr-Commit-Position: refs/branch-heads/2704@{#341}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/ab9b8915bbd8eb8d21c24de8a4929fd020b93c8f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Comment 7 Deleted

Comment 8 by qin...@chromium.org, May 10 2016

Status: Fixed (was: Started)
►

Sign in to add a comment