New issue
Advanced search Search tips

Issue 608075 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove the hard-coded values from V4LocalDatabaseManager::PopulateStoreNameMap

Project Member Reported by vakh@chromium.org, Apr 29 2016

Issue description

Introduced in https://codereview.chromium.org/1932753005/
In method: V4LocalDatabaseManager::StartOnIOThread
 

Comment 1 by vakh@chromium.org, May 6 2016

Labels: SafeBrowsing-Triaged

Comment 2 by vakh@chromium.org, Jun 10 2016

Summary: Remove the hard-coded values from V4LocalDatabaseManager::PopulateStoreNameMap (was: Remove the hard-coded values for update_list_identifier when the V4Database becomes available)

Comment 3 by vakh@chromium.org, Sep 15 2016

This is changing from a map to a vector of StoreIdAndFileName objects (see: GetStoreIdAndFileNames()).

Also, this is beginning to look like a WontFix since this seems like a good place to decide which lists/stores we are interested in fetching.

Comment 4 by vakh@chromium.org, Sep 22 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81

commit ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81
Author: vakh <vakh@chromium.org>
Date: Fri Sep 23 00:57:17 2016

1. Store list information in ListInfo (was: StoreIdAndFIleName). This includes the list identifier, list filename on disk, the SBThreatType for the list, and whether to fetch updates for this list.

2. Fixed potential leaks by inserting the client into pending_clients_ before calling GetFullHashes
(based on shess@'s feedback in 2349603003)

BUG= 543161 ,  608075 

Review-Url: https://codereview.chromium.org/2353413002
Cr-Commit-Position: refs/heads/master@{#420515}

[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/BUILD.gn
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/database_manager_unittest.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/util.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/util.h
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_database.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_database.h
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_database_unittest.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_local_database_manager.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_local_database_manager.h
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_local_database_manager_unittest.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_protocol_manager_util.cc
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_protocol_manager_util.h
[modify] https://crrev.com/ed61c9fcb2a0de50f04bbf62f9cab4de5db37a81/components/safe_browsing_db/v4_update_protocol_manager.cc

Comment 6 by vakh@chromium.org, Sep 23 2016

Status: Fixed (was: Started)

Comment 7 by vakh@chromium.org, Sep 23 2016

The values are still hardcoded in v4_local_database_manager.cc but the struct now contains all information about each list.
I believe this information belongs there so closing the bug now.

Sign in to add a comment