New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608072 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Fix --coverage-dir in test_runner.py

Project Member Reported by jbudorick@chromium.org, Apr 29 2016

Issue description

--coverage-dir used to tell the test runner where to put *.ec files. I broke it with the switch to platform-mode instrumentation tests. Make it work again, both for instrumentation tests and junit tests.
 
Components: -Test Test>Android
Status: Assigned (was: Untriaged)
Nyoba aja
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de08f6f711ebd74fe493584e0694bcce51693318

commit de08f6f711ebd74fe493584e0694bcce51693318
Author: hzl <hzl@google.com>
Date: Tue May 10 21:35:20 2016

Add directory option for JUnit coverage files.

Added runtime option --coverage-dir to let the users decide where to store
coverage.ec.

BUG= 608072 

Review-Url: https://codereview.chromium.org/1957023002
Cr-Commit-Position: refs/heads/master@{#392727}

[modify] https://crrev.com/de08f6f711ebd74fe493584e0694bcce51693318/build/android/gyp/create_java_binary_script.py
[modify] https://crrev.com/de08f6f711ebd74fe493584e0694bcce51693318/build/android/pylib/junit/test_runner.py
[modify] https://crrev.com/de08f6f711ebd74fe493584e0694bcce51693318/build/android/test_runner.py

Comment 5 by treib@chromium.org, May 11 2016

(Just posted on the CL; also here for visibility:)
The above CL breaks the build for me. I posted the error output on the CL.
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b730799f2f2f2d9d07b75f3fadd2ed387336a02

commit 0b730799f2f2f2d9d07b75f3fadd2ed387336a02
Author: jbudorick <jbudorick@chromium.org>
Date: Wed May 11 13:13:54 2016

Revert of Add directory option for JUnit coverage files. (patchset #7 id:120001 of https://codereview.chromium.org/1957023002/ )

Reason for revert:
Seemingly breaks incremental builds.

Original issue's description:
> Add directory option for JUnit coverage files.
>
> Added runtime option --coverage-dir to let the users decide where to store
> coverage.ec.
>
> BUG= 608072 
>
> Committed: https://crrev.com/de08f6f711ebd74fe493584e0694bcce51693318
> Cr-Commit-Position: refs/heads/master@{#392727}

TBR=mikecase@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 608072 

Review-Url: https://codereview.chromium.org/1973503002
Cr-Commit-Position: refs/heads/master@{#392908}

[modify] https://crrev.com/0b730799f2f2f2d9d07b75f3fadd2ed387336a02/build/android/gyp/create_java_binary_script.py
[modify] https://crrev.com/0b730799f2f2f2d9d07b75f3fadd2ed387336a02/build/android/pylib/junit/test_runner.py
[modify] https://crrev.com/0b730799f2f2f2d9d07b75f3fadd2ed387336a02/build/android/test_runner.py

Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e16476a8c069b9646370f75d71cad6cdc9c491e8

commit e16476a8c069b9646370f75d71cad6cdc9c491e8
Author: hzl <hzl@google.com>
Date: Wed May 18 18:08:43 2016

Add directory option for JUnit coverage files.

Added runtime option --coverage-dir to let the users decide where to
store coverage.ec.

BUG= 608072 

Review-Url: https://codereview.chromium.org/1965013008
Cr-Commit-Position: refs/heads/master@{#394470}

[modify] https://crrev.com/e16476a8c069b9646370f75d71cad6cdc9c491e8/build/android/gyp/create_java_binary_script.py
[modify] https://crrev.com/e16476a8c069b9646370f75d71cad6cdc9c491e8/build/android/pylib/junit/test_runner.py
[modify] https://crrev.com/e16476a8c069b9646370f75d71cad6cdc9c491e8/build/android/test_runner.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/111b5841249ab4c8e14ed1b0af2328d5e739a140

commit 111b5841249ab4c8e14ed1b0af2328d5e739a140
Author: hzl <hzl@google.com>
Date: Mon May 23 21:36:49 2016

Fixed coverage dir for instrumentation tests.

Fixed coverage dir option for instrumentation tests, so that we should
be able to pull run time coverage data from devices to bot.

BUG= 608072 

Review-Url: https://codereview.chromium.org/1964183003
Cr-Commit-Position: refs/heads/master@{#395419}

[modify] https://crrev.com/111b5841249ab4c8e14ed1b0af2328d5e739a140/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/111b5841249ab4c8e14ed1b0af2328d5e739a140/build/android/pylib/local/device/local_device_instrumentation_test_run.py

Comment 9 by hzl@chromium.org, May 31 2016

Status: Fixed (was: Assigned)

Sign in to add a comment