New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608067 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Ensure sizes test is measuring the right things on Linux

Project Member Reported by sullivan@chromium.org, Apr 29 2016

Issue description

We've moved the sizes step to the main perf waterfall, so that we're certain it runs on official release builds and we can run it on every revision. Now we'd like to ensure that it is measuring the right things.

Here is the code:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/chromium/sizes.py&q=sizes.py

Here are the graphs:
https://chromeperf.appspot.com/report?sid=a514f920dd8efd47095d638a55303444b0c85ad57d7b9308c58a37e4dcdf810e
(Lots more things to plot if you open up the "Subtest" menu)

Does this all look correct? If so, what should we monitor? It's currently set to monitor just chrome, which seems wrong. Should it be chrome-stripped?

Assigning to Rachel to find someone to answer the questions. Thanks for your help!!
 
rpop: ping? I think we will need to turn off sizes alerting on linux until this is addressed.
Cc: mmoss@chromium.org
Lei and Michael would probably be the right people to confirm what's being monitored is correct, but to my eyes yes those look like the right things.
I looked at the graph again today, and the "ChromiumPerf/linux/sizes / chrome-stripped / stripped" numbers look like the ones we care about. It's approximately what we ship to users.
Status: Fixed (was: Untriaged)
Thanks! I updated monitoring to ChromiumChrome/Google Chrome Linux x64/sizes/chrome-stripped/stripped
Cc: fmea...@chromium.org rpop@chromium.org robert...@chromium.org toyoshim@chromium.org
 Issue 606294  has been merged into this issue.

Comment 6 by rpop@chromium.org, May 23 2016

Sorry, I missed this (bad filter which is now fixed!)

Sign in to add a comment