New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608065 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Ensure sizes test is measuring the right things on Windows

Project Member Reported by sullivan@chromium.org, Apr 29 2016

Issue description

We've moved the sizes step to the main perf waterfall, so that we're certain it runs on official release builds. When we get the hardware provisioned, we can run it on every revision. Now we'd like to ensure that it is measuring the right things.

Here is the code:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/chromium/sizes.py&q=sizes.py

Here are the graphs:
64 bit: https://chromeperf.appspot.com/report?sid=eba2ad635949ffec14154c4fdca41c549d71a14aa0334f55cfe508597167e28f
32 bit: https://chromeperf.appspot.com/report?sid=d9781b15d48cc8e83fbffab2f988f8aa21a9c1e89d941fcdc542412c7b9f50b1

Does this all look correct? If so, what should we monitor? It's currently set to monitor just chrome.dll.

Assigning to Greg to answer the questions. Thanks for your help!!
 

Comment 1 by grt@chromium.org, Jul 13 2016

Cc: chrisha@chromium.org
Status: Assigned (was: Untriaged)
Could you add setup.exe and mini_installer.exe to the targets to monitor? The latter is the full installer downloaded by clients for new installs, so we certainly want to track it. Tracking setup.exe is good since it occasionally gets bloated by accidental build dependency snafus.

https://cs.chromium.org/chromium/src/chrome/installer/mini_installer/chrome.release?type=cs&q=file:mini_installer/chrome%5C.release&sq=package:chromium&l=1 lists the other binaries that are bundled into the mini_installer. If it's cheap to do so, does it make sense to monitor the sizes of everything independently?

Thanks for checking!
Status: Fixed (was: Assigned)
Monitoring updated.

Comment 3 by grt@chromium.org, Sep 15 2016

Hi sullivan: It looks like chrome.exe had a regression on Aug 11, growing by 150% (from 991,232 bytes to 2,513,408 bytes) on official builds. This is visible on the dashboard, but was a bug filed for it? If not, is there a way we can get bugs filed automagically for regressions like this? Thanks!
Ah, looks like there was a miscommunication: we were monitoring chrome.dll as per summary and setup.exe and mini_installer.exe per comment 1, looks like we should also add chrome.exe. I have fixed the monitoring so this will trigger alerts in the future.

Comment 5 by grt@chromium.org, Sep 16 2016

Awesome! Thanks.

Sign in to add a comment