OfflinePagfeModel::DeletePagesByOfflineId returns NOT_FOUND on empty list |
|||
Issue descriptionWhen passed an empty list of ids, the OfflinePagfeModel::DeletePagesByOfflineId() returns NOT_FOUND result, which should be returned when some ids were passed but not found in the database. When empty list is passed, ithe method should return OfflinePageModel::DeletePageResult::SUCCESS
,
Jun 20 2016
taking this over as time filler.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c0a99cc4e0b602137448367b4b070875e6e0d67 commit 2c0a99cc4e0b602137448367b4b070875e6e0d67 Author: romax <romax@chromium.org> Date: Wed Jun 22 18:18:40 2016 [Offline Pages] Fix cases where returning NOT_FOUND when deleting. We were returning NOT_FOUND when trying to delete an empty list of offline ids instead of SUCCESS. NOT_FOUND should only be used only when some ids that were passed in cannot be found in the database. BUG= 608057 Review-Url: https://codereview.chromium.org/2086733002 Cr-Commit-Position: refs/heads/master@{#401353} [modify] https://crrev.com/2c0a99cc4e0b602137448367b4b070875e6e0d67/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java [modify] https://crrev.com/2c0a99cc4e0b602137448367b4b070875e6e0d67/chrome/browser/android/offline_pages/recent_tab_helper.cc [modify] https://crrev.com/2c0a99cc4e0b602137448367b4b070875e6e0d67/components/offline_pages/offline_page_model.h [modify] https://crrev.com/2c0a99cc4e0b602137448367b4b070875e6e0d67/components/offline_pages/offline_page_model_impl.cc [modify] https://crrev.com/2c0a99cc4e0b602137448367b4b070875e6e0d67/components/offline_pages/offline_page_model_impl_unittest.cc [modify] https://crrev.com/2c0a99cc4e0b602137448367b4b070875e6e0d67/components/offline_pages/offline_page_types.h
,
Jun 22 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fgor...@chromium.org
, May 11 2016Status: Assigned (was: Untriaged)