UNADDRESSABLE ACCESS in SafeBrowsingV4GetHashProtocolManagerTest_TestGetHashErrorHandlingNetwork |
|||||||
Issue descriptionIt started on https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/4639 I suspect one of these changes is culprit: https://codereview.chromium.org/1843383002 https://codereview.chromium.org/1881353002 kcarattini@, can you look into this? UNADDRESSABLE ACCESS: reading 0x0000000c-0x00000010 4 byte(s) # 0 safe_browsing::V4GetHashProtocolManager::Create [components\safe_browsing_db\v4_get_hash_protocol_manager.cc:99] # 1 safe_browsing::SafeBrowsingV4GetHashProtocolManagerTest_TestGetHashErrorHandlingNetwork_Test::TestBody [components\safe_browsing_db\v4_get_hash_protocol_manager_unittest.cc:88] # 2 testing::internal::HandleExceptionsInMethodIfSupported<> [testing\gtest\src\gtest.cc:2458] Note: @0:04:09.850 in thread 4228 Note: instruction: call 0x04(%eax) %esp -> %esp 0xfffffffc(%esp) Suppression (error hash=#25B5D62ECF719C5E#): For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the- { UNADDRESSABLE ACCESS name=<insert_a_suppression_name_here> *!safe_browsing::V4GetHashProtocolManager::Create *!safe_browsing::SafeBrowsingV4GetHashProtocolManagerTest_TestGetHashErrorHandlingNetwork_Test::TestBody *!testing::internal::HandleExceptionsInMethodIfSupported<> }
,
Apr 30 2016
,
Apr 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc260975054dcacc3d5c0ac36cecec6bc6fba9a1 commit fc260975054dcacc3d5c0ac36cecec6bc6fba9a1 Author: oshima <oshima@chromium.org> Date: Sat Apr 30 07:41:45 2016 Exclude more tests in SafeBrowsingV4GetHashProtocolManagerTest BUG= 608053 TBR=kcarattini@chromium.o Review-Url: https://codereview.chromium.org/1938763002 Cr-Commit-Position: refs/heads/master@{#390849} [modify] https://crrev.com/fc260975054dcacc3d5c0ac36cecec6bc6fba9a1/tools/valgrind/gtest_exclude/components_unittests.gtest-drmemory_win32.txt
,
May 2 2016
,
May 2 2016
+todya's sheriff. SafeBrowsingV4GetHashProtocolManagerTest.TestParseHashResponse is now failing https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/4755 We probably should exclude all of SafeBrowsingVGGetHashProtocolManagerTest, or revert culprit.
,
May 2 2016
+benwells@
,
May 2 2016
I find V4GetHashProtocolManager::RegisterFactory suspicious. kcarattini@chromium.org recently added a test that registers a stack variable as the factory instance but doesn't clear it afterwards. Not only will this leak an existing factory if it exists but is a use-after-free for any later tests (if they share the process): https://codereview.chromium.org/1843383002
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/177293e05b9ca513af66dd2b2c22df19b94638a5 commit 177293e05b9ca513af66dd2b2c22df19b94638a5 Author: reillyg <reillyg@chromium.org> Date: Mon May 02 21:22:48 2016 Add suppressions for issues 608053 and 608064 . This should be more effective than disabling individual tests as these errors have been seen across many tests. BUG= 608053 , 608064 TBR=oshima@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/1937403002 Cr-Commit-Position: refs/heads/master@{#391053} [modify] https://crrev.com/177293e05b9ca513af66dd2b2c22df19b94638a5/tools/valgrind/drmemory/suppressions.txt
,
May 2 2016
I'm about to send out a review for a fix.
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea614851dc01884f58559b520c5a013a9beb2e2 commit 3ea614851dc01884f58559b520c5a013a9beb2e2 Author: reillyg <reillyg@chromium.org> Date: Tue May 03 20:17:14 2016 Make V4GetHashProtocolManager::RegisterFactory safe. This patch makes V4GetHashProtocolManager::RegisterFactory safe by passing ownership of the testing factory and making sure it is cleared before the next test is run. BUG= 608053 Review-Url: https://codereview.chromium.org/1944433002 Cr-Commit-Position: refs/heads/master@{#391339} [modify] https://crrev.com/3ea614851dc01884f58559b520c5a013a9beb2e2/components/safe_browsing_db/database_manager_unittest.cc [modify] https://crrev.com/3ea614851dc01884f58559b520c5a013a9beb2e2/components/safe_browsing_db/v4_get_hash_protocol_manager.cc [modify] https://crrev.com/3ea614851dc01884f58559b520c5a013a9beb2e2/components/safe_browsing_db/v4_get_hash_protocol_manager.h [modify] https://crrev.com/3ea614851dc01884f58559b520c5a013a9beb2e2/tools/valgrind/drmemory/suppressions.txt [modify] https://crrev.com/3ea614851dc01884f58559b520c5a013a9beb2e2/tools/valgrind/gtest_exclude/components_unittests.gtest-drmemory_win32.txt
,
May 3 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 29 2016