Debug build chromium crashed after enabling account permission. |
||
Issue descriptionVersion: TOT OS: Android What steps will reproduce the problem? (1) start chromium with FRE, go into data saver screen (now chrome has no permission to access account on device). (2) go to device app setting, chromium, permission, enable contact access (3) switch back to chromium. Crashed. I think it only crashes on debug build since it was caused by DCHECK directly, but its a potential bug. Log: 04-29 16:15:07.791 15713 15713 E chromium: [ERROR:profile_downloader_android.cc(201)] Attempted to get AccountInfo for account not in the AccountTrackerService 04-29 16:15:07.832 15713 15713 F chromium: [FATAL:signin_investigator.cc(31)] Check failed: !current_id_.empty(). 04-29 16:15:07.832 15713 15713 F chromium: #00 0x84f52869 /data/app/org.chromium.chrome-1/lib/arm/libchrome_public.so+0x00589869 04-29 16:15:07.832 15713 15713 F chromium: #01 0x87166d39 /data/app/org.chromium.chrome-1/lib/arm/libchrome_public.so+0x0279dd39 04-29 16:15:07.832 15713 15713 F chromium: #02 0x84e87371 /data/app/org.chromium.chrome-1/lib/arm/libchrome_public.so+0x004be371 04-29 16:15:07.832 15713 15713 F chromium: #03 0x84e873d9 /data/app/org.chromium.chrome-1/lib/arm/libchrome_public.so+0x004be3d9 04-29 16:15:07.832 15713 15713 F chromium: #04 0xa0245601 /data/app/org.chromium.chrome-1/oat/arm/base.odex+0x01804601 @skym assign it to you since you have written related codes (signin_investigator).
,
Apr 29 2016
Oh, nvm you specified Android.
,
Apr 29 2016
I think I made a mistake adding that DCHECK. Looking at the comment at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/android/signin/signin_investigator_android.cc&sq=package:chromium&type=cs&q=SigninInvestigator&l=32 it seems like getting an empty account_id should be a completely valid scenario. The rest of the class even checks if it's empty or not. Will post a CL shortly removing it.
,
Apr 29 2016
we may probably need to look into it a little bit more since I saw this warning 04-29 16:15:07.791 15713 15713 E chromium: [ERROR:profile_downloader_android.cc(201)] Attempted to get AccountInfo for account not in the AccountTrackerService
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9d3ac5f7798a2d5fa8a4965fb5a6c2bbda92aa4 commit f9d3ac5f7798a2d5fa8a4965fb5a6c2bbda92aa4 Author: skym <skym@chromium.org> Date: Mon May 02 15:37:56 2016 [Sync] Removed a DCHECK in SigninInvestigator for a valid scenario. BUG=608029 Review-Url: https://codereview.chromium.org/1932343003 Cr-Commit-Position: refs/heads/master@{#390947} [modify] https://crrev.com/f9d3ac5f7798a2d5fa8a4965fb5a6c2bbda92aa4/components/signin/core/browser/signin_investigator.cc [modify] https://crrev.com/f9d3ac5f7798a2d5fa8a4965fb5a6c2bbda92aa4/components/signin/core/browser/signin_investigator_unittest.cc
,
May 2 2016
DCHECK has been removed. Reassigning to you, gogerald@, to investigate the profile_downloader_android.cc issue. Let me know if there's anything else I can do to help. |
||
►
Sign in to add a comment |
||
Comment 1 by s...@chromium.org
, Apr 29 2016