New issue
Advanced search Search tips

Issue 608023 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 477150
issue 472642



Sign in to add a comment

http/tests/inspector/injected-script-for-origin.html fails with --site-per-process

Project Member Reported by lukasza@chromium.org, Apr 29 2016

Issue description

Repro:

$ ninja ... blink_tests
$ third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn -v --additional-drt-flag=--site-per-process --additional-drt-flag=--no-sandbox http/tests/inspector/injected-script-for-origin.html

Expected behavior: Test passes.

Actual behavior: Test fails.

FWIW, I see that setInjectedScriptForOrigin is called in another renderer process, from the two renderer processes that end up running 2 instances of   inspector/resources/injected-script-for-origin-frame.html (which inspect window.foo and get back <undefined> with --site-per-process):

[29712:29712:0429/130711:2431668469735:ERROR:test_runner.cc(610)] Calling setInjectedScriptForOrigin
[29735:29735:0429/130711:2431668585713:ERROR:test_runner.cc(610)] location.href=http://127.0.0.1:8000/inspector/resources/injected-script-for-origin-frame.html
[29735:29735:0429/130711:2431668587709:ERROR:test_runner.cc(610)] data=undefined
[29737:29737:0429/130711:2431668600910:ERROR:test_runner.cc(610)] location.href=http://localhost:8000/inspector/resources/injected-script-for-origin-frame.html
[29737:29737:0429/130711:2431668602878:ERROR:test_runner.cc(610)] data=undefined
 
dgozman@ - could you please help verify if this test failure uncovers any product bugs (vs is a test-only issue that shouldn't impact first OOPIF launch via --isolate-extensions)?
Blocking: -451004 472642
Status: Assigned (was: Untriaged)
This is a test for our extensions mechanism, which are whitelisted from site-per-process in production for now. I think it doesn't work just because whitelisting is done for chrome-devtools:// scheme, while layout tests use http.
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd0f3201a2bc6c1d30dfc8a5a23eeeaedf56e2b

commit 6bd0f3201a2bc6c1d30dfc8a5a23eeeaedf56e2b
Author: lukasza <lukasza@chromium.org>
Date: Tue May 03 16:26:14 2016

Triaging some of the remaining site-per-process layout test failures.

Most of the changes in this CL just moved test expectations around and
added comments with bug pointers.

One exception is that http/tests/appcache/remove-cache.html expectation
has been removed altogether:
- this test passes on the Site Isolation FYI
- flakiness is already called out in  https://crbug.com/518929 
- locally I see a failure with and without --site-per-process, but since
  the bots are happy we should just remove the exception I think

BUG= 582211 ,  608015 ,  608023 ,  606594 ,  607991 ,  607981 

Review-Url: https://codereview.chromium.org/1931143002
Cr-Commit-Position: refs/heads/master@{#391262}

[modify] https://crrev.com/6bd0f3201a2bc6c1d30dfc8a5a23eeeaedf56e2b/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Comment 4 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Comment 5 by sshru...@google.com, May 18 2016

Components: -Blink>LayoutTests
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.
Status: WontFix (was: Assigned)
Removing the test, extensions tests are testing this functionality now.

Sign in to add a comment