Clean up //mojo |
|||
Issue descriptionThere's a lot of cruft in //mojo. Quick breakdown: android/ <-- what's this for? build/ <-- seems old, obsolete? common/ <-- Ken asks if this should be part of the public client lib. converters/ <-- layering violation, should be elsewhere in tree gles2/, gpu/ <-- ?? logging/ <-- unnecessary with base/logging? platform_handle/ <-- move to common/ client lib? test/ <-- what's all this then? util/ <-- move elsewhere Seems like this directory could use vacuuming.
,
May 25 2016
Given your description, should mojo/android live under mojo/edk/android?
,
May 25 2016
Yes, I think that makes sense
,
Jul 11 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/110b797e9ba759d96e5c44f665259b4fa51b440a commit 110b797e9ba759d96e5c44f665259b4fa51b440a Author: sadrul <sadrul@chromium.org> Date: Tue Nov 29 03:27:12 2016 mojo/gpu: Remove dead gpu code. This code is no longer used. So remove this. BUG= 608017 TBR=piman@ because presubmit checks after the patch. Review-Url: https://codereview.chromium.org/2535993002 Cr-Commit-Position: refs/heads/master@{#434867} [delete] https://crrev.com/3cb41a69e160c567b859273092576d65235f3968/mojo/gpu/BUILD.gn [delete] https://crrev.com/3cb41a69e160c567b859273092576d65235f3968/mojo/gpu/DEPS [delete] https://crrev.com/3cb41a69e160c567b859273092576d65235f3968/mojo/gpu/OWNERS [delete] https://crrev.com/3cb41a69e160c567b859273092576d65235f3968/mojo/gpu/mojo_gles2_impl_autogen.cc [delete] https://crrev.com/3cb41a69e160c567b859273092576d65235f3968/mojo/gpu/mojo_gles2_impl_autogen.h
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23ffd510d988a0f266f30fb8ccdf70cbc77da1e9 commit 23ffd510d988a0f266f30fb8ccdf70cbc77da1e9 Author: sammc <sammc@chromium.org> Date: Tue Jan 03 22:45:01 2017 Remove unused parts of //mojo/common. BUG= 608017 Review-Url: https://codereview.chromium.org/2608173002 Cr-Commit-Position: refs/heads/master@{#441228} [modify] https://crrev.com/23ffd510d988a0f266f30fb8ccdf70cbc77da1e9/mojo/common/BUILD.gn [modify] https://crrev.com/23ffd510d988a0f266f30fb8ccdf70cbc77da1e9/mojo/common/DEPS [delete] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/mojo/common/data_pipe_file_utils.cc [modify] https://crrev.com/23ffd510d988a0f266f30fb8ccdf70cbc77da1e9/mojo/common/data_pipe_utils.cc [modify] https://crrev.com/23ffd510d988a0f266f30fb8ccdf70cbc77da1e9/mojo/common/data_pipe_utils.h [delete] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/mojo/common/user_agent.cc [delete] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/mojo/common/user_agent.h
,
May 29 2017
Calling this fixed. All that's left is mojo/common which is all base:: typemapping stuff, and there's already a separate bug to track moving this to //base/mojom. |
|||
►
Sign in to add a comment |
|||
Comment 1 by roc...@chromium.org
, Apr 29 2016