http/tests/inspector-protocol/access-inspected-object.html fails with --site-per-process |
|||||
Issue description
Repro:
$ ninja ... blink_tests
$ third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn -v --additional-drt-flag=--site-per-process --additional-drt-flag=--no-sandbox http/tests/inspector-protocol/access-inspected-object.html
Expected behavior: Test passes.
Actual behavior: Test fails.
When iframeRequestHandler (in http/tests/inspector-protocol/access-inspected-object.html: line 31) is called, it tries to access note.contentDocument.nodeId. It turns out that note.contentDocument is undefined (which might be expected if this is a cross-site document leaving in an OOPIF).
Exception when dispatching message: TypeError: Cannot read property 'nodeId' of undefined
TypeError: Cannot read property 'nodeId' of undefined
at iframeRequestHandler (eval at <anonymous> (http://127.0.0.1:8000/inspector-protocol/resources/protocol-test.html:179:9), <anonymous>:37:47)
at Object.DevToolsAPI.dispatchMessage (http://127.0.0.1:8000/inspector-protocol/resources/protocol-test.html:164:17)
at <anonymous>:1:13
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bd0f3201a2bc6c1d30dfc8a5a23eeeaedf56e2b commit 6bd0f3201a2bc6c1d30dfc8a5a23eeeaedf56e2b Author: lukasza <lukasza@chromium.org> Date: Tue May 03 16:26:14 2016 Triaging some of the remaining site-per-process layout test failures. Most of the changes in this CL just moved test expectations around and added comments with bug pointers. One exception is that http/tests/appcache/remove-cache.html expectation has been removed altogether: - this test passes on the Site Isolation FYI - flakiness is already called out in https://crbug.com/518929 - locally I see a failure with and without --site-per-process, but since the bots are happy we should just remove the exception I think BUG= 582211 , 608015 , 608023 , 606594 , 607991 , 607981 Review-Url: https://codereview.chromium.org/1931143002 Cr-Commit-Position: refs/heads/master@{#391262} [modify] https://crrev.com/6bd0f3201a2bc6c1d30dfc8a5a23eeeaedf56e2b/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
May 18 2016
,
May 18 2016
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.
,
Oct 4 2017
,
Dec 5
Tests are triaged separately |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by lukasza@chromium.org
, Apr 29 2016