New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608001 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

gcapi's GoogleChromeCompatibilityCheck should indicate that XP and Vista are unfit for Chrome

Project Member Reported by grt@chromium.org, Apr 29 2016

Issue description

Summary says it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91972dd1816b3b1f658622ee5ef89c98b36a3f4e

commit 91972dd1816b3b1f658622ee5ef89c98b36a3f4e
Author: zmin <zmin@chromium.org>
Date: Tue May 03 17:34:28 2016

GoogleChromeCompatibilityCheck in gcapi return false for Windows XP and Vista

BUG= 608001 

Review-Url: https://codereview.chromium.org/1943943002
Cr-Commit-Position: refs/heads/master@{#391284}

[modify] https://crrev.com/91972dd1816b3b1f658622ee5ef89c98b36a3f4e/chrome/installer/gcapi/gcapi.cc

Comment 2 by grt@chromium.org, May 3 2016

Labels: Merge-Request-50
Status: Fixed (was: Assigned)
Requesting a late merge into M50 so that we can pluck a build of this binary off of the official builder. We can't use a ToT build, as base now links to symbols that aren't present on XP/Vista. This merge should be extremely low risk as it does not impact the product "Google Chrome." I'll let rpop@ comment on whether we can wait until some future M50 build, or if we'd like to request a special build so we can pull the .dll. Thanks.

Comment 3 by rpop@chromium.org, May 3 2016

Cc: tinazh@chromium.org
+Tinazh explicitly for desktop M50. The sooner we get an official build, the sooner we can stop distributing M49. I'd say we should do one for this, but Tina should decide.

Comment 4 by tin...@google.com, May 3 2016

Cc: gov...@chromium.org
+ govind@ as she manages M50 post-stable refresh. M51 stable for desktop will launch in about 3 weeks, which we'd still be distributing M49 for unsupported OSs then, and can be a good launch vehicle to ride with?
Cc: manoranj...@chromium.org

Comment 6 by tin...@google.com, May 4 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M50), manual review required.

Comment 7 by grt@chromium.org, May 5 2016

I don't think we can pull this from an M51 build since I imagine that base/ no longer works on XP on that branch. I think we may need to do an M49 checkout and make an "official" build on a dev box. We don't sign this binary to my knowledge, so this should suffice to get bits we can ship to partners.

That said, it will be less time/effort on our part if we could merge this to M50 and trigger an official build. What are the costs involved in doing that?

Comment 8 by tin...@google.com, May 5 2016

Labels: -Merge-Review-50 Merge-Approved-50
checked with grt@ and this actually doesn't need to ship a M50 stable refresh but just need a way to generate an official build to produce the .zip file that goes into the unsigned binaries storage bucket.

Also to add, per grt@ This code doesn't actually go into shipping Chrome builds. So it won't be a problem for it to be present if a future M50 stable refresh is made/shipped.

Merge approved for this purpose for M50 (branch 2661).

govind@ can you pls manage to trigger an M50 build once the merge in? Thanks.
Reply to comment #8, Sure, I will trigger an M50 build once the merge is in.
Project Member

Comment 10 by bugdroid1@chromium.org, May 5 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26377eabf67af9cd4140a4d77b53ddcd146c558e

commit 26377eabf67af9cd4140a4d77b53ddcd146c558e
Author: Greg Thompson <grt@chromium.org>
Date: Thu May 05 19:07:57 2016

GoogleChromeCompatibilityCheck in gcapi return false for Windows XP and Vista

BUG= 608001 

Review-Url: https://codereview.chromium.org/1943943002
Cr-Commit-Position: refs/heads/master@{#391284}
(cherry picked from commit 91972dd1816b3b1f658622ee5ef89c98b36a3f4e)
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/1953103002 .

Cr-Commit-Position: refs/branch-heads/2661@{#656}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/26377eabf67af9cd4140a4d77b53ddcd146c558e/chrome/installer/gcapi/gcapi.cc

Thank you for M50 merge. Triggering M50 build now.

Comment 12 by grt@chromium.org, May 5 2016

Thank you!
I have checked the test function GoogleChromeCompatabilityCHeck on below OS's using Owen Script  and below are the results :

Windows XP : "OS is not supported 8"
Windows Vista : "OS is not supported 8" 

Windows 7 : "OS is supported"
Windows 8.1 : "OS is supported"
Windows 10 : " OS is supported"

Please let me know if I need to check anything which I have missed, If everything looks good I will mark the bug as verified.

Sign in to add a comment