New issue
Advanced search Search tips

Issue 607990 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

git cl description -d doesn't work on a gerrit change in a rietveld repo

Project Member Reported by martiniss@chromium.org, Apr 29 2016

Issue description

If I run git cl description -d https://chrome-internal-review.googlesource.com/c/252679/ --gerrit in depot_tools, it errors with 

Traceback (most recent call last):
  File "./git_cl.py", line 4871, in <module>
    sys.exit(main(sys.argv[1:]))
  File "./git_cl.py", line 4853, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/s/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "./git_cl.py", line 3304, in CMDdescription
    description = ChangeDescription(cl.GetDescription())
  File "./git_cl.py", line 1219, in GetDescription
    self.description = self._codereview_impl.FetchDescription()
  File "./git_cl.py", line 2177, in FetchDescription
    current_rev = data['current_revision']
TypeError: 'NoneType' object has no attribute '__getitem__'
 

Which I believe is it not getting any info from the gerrit server.

If I run it from the gerrit repo, then it gives me the correct value.

Not sure why this happens, and it's not blocking me right now, but it should probably be fixed.
 

Comment 1 by tandrii@google.com, Apr 29 2016

FTR, depot_tools specifically has no Gerrit enabled for it, because it's an SVN repo :( With luck by end of Q2 it will be pure git.

Anyway, your problem is due to your code ignoring provided server URL. Thus, it tries to determine Gerrit URL based on current git repo's url. Depot_tools is in public host, so it's lookin 252679 in chromium-review.googlesource.com.
If you were running it in say /tmp, you'd actually get nothing too.

See also  comment on https://codereview.chromium.org/1935653002/ 
Status: WontFix (was: Untriaged)
Closing this as WontFix, please re-open with clarification if you think bug is here.

Sign in to add a comment