CrossProcessFrameConnector::OnFrameRectChanged() needs to know when WebView is zooming a child without zooming the parent. |
||
Issue descriptionAfter https://codereview.chromium.org/1804023002/ lands, the WebView.setZoomAPI will be broken when the --use-cross-process-frames-for-guests flag is specified. Specifically, we don't want the parent to change its frame rect size for the child, which is what seems to be happening now. Since there can potentially be both OOPIFs and OOPIF-based WebViews active at the same time, CrossProcessFrameConnector needs a way to know the origin of the zoom event in order to decide about resizing the frame rect.
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a767092b45f7eafcc57c704f536d05bdf953c773 commit a767092b45f7eafcc57c704f536d05bdf953c773 Author: wjmaclean <wjmaclean@chromium.org> Date: Fri May 06 17:06:18 2016 SendPageMessage() should not send to a WebView guest's embedder. The test failure in the bug listed below is due to SendPageMessage(), when initiated from the guest's WebContentsImpl(), inadvertently sending messages to the embedder. For zoom messages this is inappropriate, and for all messages seems to run counter to the notion of the 'page' being the frames owned by the WebContents. BUG= 607978 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/1949163002 Cr-Commit-Position: refs/heads/master@{#392081} [modify] https://crrev.com/a767092b45f7eafcc57c704f536d05bdf953c773/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/a767092b45f7eafcc57c704f536d05bdf953c773/content/browser/frame_host/render_frame_host_manager.cc
,
May 6 2016
The landed CL should fix this, as verified by the re-enabled test.
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cba6b3081e6bfab05d4874d91f0de8653a80b12e commit cba6b3081e6bfab05d4874d91f0de8653a80b12e Author: wjmaclean <wjmaclean@chromium.org> Date: Tue May 31 00:25:07 2016 Remove stale TODO. The associated bug for this TODO is closed, and the comment is stale. BUG= 607978 TBR=creis@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2021143002 Cr-Commit-Position: refs/heads/master@{#396761} [modify] https://crrev.com/cba6b3081e6bfab05d4874d91f0de8653a80b12e/content/browser/frame_host/cross_process_frame_connector.cc |
||
►
Sign in to add a comment |
||
Comment 1 Deleted