New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607971 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 587995



Sign in to add a comment

PaymentRequest shipping address labels

Project Member Reported by rouslan@chromium.org, Apr 29 2016

Issue description

The PaymentRequest UI should show the shipping address on two lines:     
                                                                         
LABEL: The address on a single line without the name of the recipient.   

SUB-LABEL: The name of the recipient. 

This bug is for Android, which the first platform to have PaymentRequest UI for now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eaf0ec1e4640410c82c86734af5f60b3fd0532a

commit 5eaf0ec1e4640410c82c86734af5f60b3fd0532a
Author: rouslan <rouslan@chromium.org>
Date: Fri Apr 29 23:04:40 2016

PaymentRequest shipping address labels.

The PaymentRequest UI should show the shipping address on two lines:

LABEL: The address on a single line without the name of the recipient.
SUB-LABEL: The name of the recipient.

BUG= 607971 

Review-Url: https://codereview.chromium.org/1937563002
Cr-Commit-Position: refs/heads/master@{#390795}

[modify] https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
[modify] https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a/chrome/browser/autofill/android/personal_data_manager_android.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/142b98e4d3b296b478eb5e549edb3ab2797a5f52

commit 142b98e4d3b296b478eb5e549edb3ab2797a5f52
Author: mdjones <mdjones@chromium.org>
Date: Fri Apr 29 23:41:59 2016

Revert of PaymentRequest shipping address labels. (patchset #1 id:20001 of https://codereview.chromium.org/1937563002/ )

Reason for revert:
Compile broken on clang-clankium-tot-builder and instrumentation-mako-clankium-tot. (AutofillDialogControllerImpl.java calls getProfiles())

Original issue's description:
> PaymentRequest shipping address labels.
>
> The PaymentRequest UI should show the shipping address on two lines:
>
> LABEL: The address on a single line without the name of the recipient.
> SUB-LABEL: The name of the recipient.
>
> BUG= 607971 

TBR=dfalcantara@chromium.org,mathp@chromium.org,rouslan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 607971 

Review-Url: https://codereview.chromium.org/1929163004
Cr-Commit-Position: refs/heads/master@{#390803}

[modify] https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
[modify] https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52/chrome/browser/autofill/android/personal_data_manager_android.h

Labels: M-53

Sign in to add a comment