New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607951 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Itoa conversion issue in QuicStreamSequencerBuffer logging QUIC_OVERLAPPING_STREAM_FRAME

Project Member Reported by danzh@chromium.org, Apr 29 2016

Issue description

There is a itoa conversion issue in QuicStreamSequencerBuffer which converts a unsigned int to signed int.

string RangeDebugString(QuicStreamOffset start, QuicStreamOffset end) {
  return string("[") + base::IntToString(start) + ", " +
         base::IntToString(end) + ") ";
}

https://code.google.com/p/chromium/codesearch#chromium/src/net/quic/quic_stream_sequencer_buffer.cc&l=19

This effects the debug string for QUIC_OVERLAPPING_STREAM_FRAME, which supposed to be something like this:
Beginning of received data overlaps with buffered data.
New frame range [1024, 2048) 
Currently received frames: 
Current gaps: [1447, MAX_QUIC_STREAM_OFFSET) 

However it prints out as this:
Beginning of received data overlaps with buffered data.
New frame range [1024, 2048) 
Currently received frames: 
Current gaps: [1447, -1) 

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb045901a77328363e79747d6466c59320374eb3

commit eb045901a77328363e79747d6466c59320374eb3
Author: danzh <danzh@google.com>
Date: Fri May 06 19:50:05 2016

Fix a QuicStreamSequencerBuffer logging issue caused by inapproriate itoa function.

R=rch@chromium.org
BUG= 607951 

Review-Url: https://codereview.chromium.org/1954183002
Cr-Commit-Position: refs/heads/master@{#392130}

[modify] https://crrev.com/eb045901a77328363e79747d6466c59320374eb3/net/quic/quic_stream_sequencer_buffer.cc

Comment 2 by danzh@chromium.org, May 6 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment