New issue
Advanced search Search tips

Issue 607950 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task



Sign in to add a comment

Make implementation of LibsecretAttributesBuilder more robust

Project Member Reported by cfroussios@chromium.org, Apr 29 2016

Issue description

In LibsecretAttributesBuilder, the internals of the name_values_ container are referenced by external objects. These references can break, depending on the implementation details of the container. For example, std::list works but std::vector fails the asan tests.

We should provide the needed storage in an alternative way, such that the references don't depend on implementation details.
 

Comment 1 by vabr@chromium.org, Jun 6 2016

Labels: -refactoring Hotlist-Refactoring
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 6 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by vabr@chromium.org, Oct 23 2017

Components: -UI>Browser>Passwords Internals>LocalDataEncryption
Labels: -Type-Feature Hotlist-TechnicalDebt Type-Task
Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 23

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
This change is aesthetic for the code and won't have actual impact. Let's not expect that someone will invest time on this

Sign in to add a comment