Add RAPPOR metrics for media pipeline errors. |
||||||||
Issue descriptionThis would provide information about sites that serve bad or unsupported media contents to Chromium to help investigation/debugging.
,
May 24 2016
,
Jun 15 2016
Urr, I found a typo in the original CL. Fix CL is at https://chromiumcodereview.appspot.com/2061393002/ Since the fix is super trivial and we do want this to be in M52 to collect data earlier. I'll try to merge the fix to M52.
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b81daa043ac6c4aeecd2a99aa055ac20fdc6511 commit 0b81daa043ac6c4aeecd2a99aa055ac20fdc6511 Author: xhwang <xhwang@chromium.org> Date: Wed Jun 15 05:08:23 2016 media: Fix a typo in PipelineError rappor reporting Apparently I was missing a "." :( BUG= 607949 TEST=Verified the name is correct now. Review-Url: https://codereview.chromium.org/2061393002 Cr-Commit-Position: refs/heads/master@{#399846} [modify] https://crrev.com/0b81daa043ac6c4aeecd2a99aa055ac20fdc6511/media/blink/webmediaplayer_util.cc
,
Jun 15 2016
See #3, the fix is super trivial and I'd like to merge the fix so that we can get data from stable channel earlier.
,
Jun 16 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 16 2016
xhwang@, can you please let us know if this can be tested manually so that we can verify it on Canary ? PS: Please also get this merged in to M52 branch once it is verified on Canary before 6/22 so that it gets picked for Beta promotion scheduled next week.
,
Jun 16 2016
I don't really see an easy way to verify this manually other than running a debug build with extra logging enabled. It's just a fix of a typo and I've already verified it on my machine. Shall I go ahead and merge the fix?
,
Jun 16 2016
Thank you xhwang@ for the update and verifying this. Please go ahead and merge the CL in to M52 branch.
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87331b51a6eca1302e51f3ac47576b5f2574353b commit 87331b51a6eca1302e51f3ac47576b5f2574353b Author: Xiaohan Wang <xhwang@chromium.org> Date: Thu Jun 16 23:41:08 2016 media: Fix a typo in PipelineError rappor reporting Apparently I was missing a "." :( BUG= 607949 TEST=Verified the name is correct now. Review-Url: https://codereview.chromium.org/2061393002 Cr-Commit-Position: refs/heads/master@{#399846} (cherry picked from commit 0b81daa043ac6c4aeecd2a99aa055ac20fdc6511) Review URL: https://codereview.chromium.org/2072953002 . Cr-Commit-Position: refs/branch-heads/2743@{#374} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/87331b51a6eca1302e51f3ac47576b5f2574353b/media/blink/webmediaplayer_util.cc
,
Jun 17 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, May 2 2016