New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607945 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: May 2016
Cc:
█ mkwst@chromium.org
sabineb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 400674



Sign in to add a comment

Blacklisting doesn't work for federated credentials

Project Member Reported by vasi...@chromium.org, Apr 29 2016 
Version: 51
OS: all

What steps will reproduce the problem?
(1) Visit https://w3c.github.io/webappsec/demos/credential-management/ 
(2) Submit a credential and click 'Never'
(3) Try to sign in with a federated credential

What is the expected output?
No bubble.

What do you see instead?
The bubble pops up.

Comment 1 by sabineb@chromium.org, May 1 2016

Labels: -Pri-3 Pri-1

Comment 2 by vasi...@chromium.org, May 2 2016

Status: Fixed (was: Started)

Comment 3 by vasi...@chromium.org, May 3 2016

Status: Started (was: Fixed)
Project Member

Comment 4 by bugdroid1@chromium.org, May 3 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/77855a3cbf2e39f0a4dcff66bad1d61179e77160

commit 77855a3cbf2e39f0a4dcff66bad1d61179e77160
Author: vabr <vabr@google.com>
Date: Tue May 03 16:07:43 2016
Project Member

Comment 5 by bugdroid1@chromium.org, May 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60883bfb1b4e342024a59b402924abdc23db596a

commit 60883bfb1b4e342024a59b402924abdc23db596a
Author: vasilii <vasilii@chromium.org>
Date: Tue May 03 16:24:52 2016

Fix blacklisting password forms with Credential Manager API.

The fix has two parts. Blacklisting the federated credential now works. The password bubble doesn't pop up for a federated credential when the site is blacklisted.

BUG= 607945 

Review-Url: https://codereview.chromium.org/1946563003
Cr-Commit-Position: refs/heads/master@{#391260}

[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/content/browser/credential_manager_impl.cc
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/content/browser/credential_manager_impl_unittest.cc
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/core/browser/credential_manager_password_form_manager.cc
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/core/browser/credential_manager_password_form_manager.h
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/core/browser/test_password_store.cc
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/core/common/credential_manager_types.cc
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/core/common/credential_manager_types.h
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/components/password_manager/core/common/credential_manager_types_unittest.cc
[modify] https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a/ios/chrome/browser/passwords/credential_manager.mm
Project Member

Comment 6 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/deafb611a206184c2ef316bd50e11b9663cc6756

commit deafb611a206184c2ef316bd50e11b9663cc6756
Author: vabr <vabr@google.com>
Date: Wed May 04 06:53:27 2016

Comment 7 by vasi...@chromium.org, May 4 2016

Labels: Merge-Request-51
I want to merge r391260 back. The fix is important for the API launch.

Comment 8 by sshru...@google.com, May 5 2016

Labels: OS-All

Comment 9 by tin...@google.com, May 5 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 10 by bugdroid1@chromium.org, May 6 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84c2b499e62b79b728de94e0f3f3f109d619c6c4

commit 84c2b499e62b79b728de94e0f3f3f109d619c6c4
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri May 06 10:21:26 2016

Fix blacklisting password forms with Credential Manager API.

The fix has two parts. Blacklisting the federated credential now works. The password bubble doesn't pop up for a federated credential when the site is blacklisted.

BUG= 607945 
TBR=vabr@chromium.org

Review-Url: https://codereview.chromium.org/1946563003
Cr-Commit-Position: refs/heads/master@{#391260}
(cherry picked from commit 60883bfb1b4e342024a59b402924abdc23db596a)

Review URL: https://codereview.chromium.org/1960653002 .

Cr-Commit-Position: refs/branch-heads/2704@{#415}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/content/browser/credential_manager_dispatcher.cc
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/core/browser/credential_manager_password_form_manager.cc
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/core/browser/credential_manager_password_form_manager.h
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/core/browser/test_password_store.cc
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/core/common/credential_manager_types.cc
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/core/common/credential_manager_types.h
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/components/password_manager/core/common/credential_manager_types_unittest.cc
[modify] https://crrev.com/84c2b499e62b79b728de94e0f3f3f109d619c6c4/ios/chrome/browser/passwords/credential_manager.mm

Comment 11 by vasi...@chromium.org, May 6 2016

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/faaef4b9583ce84db25ecf59eb8e6a745eaa0b72

commit faaef4b9583ce84db25ecf59eb8e6a745eaa0b72
Author: vabr <vabr@google.com>
Date: Tue May 03 16:07:43 2016
Project Member

Comment 13 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/a5b172ad09acaa89f49d0d06d00d48f77337a6b8

commit a5b172ad09acaa89f49d0d06d00d48f77337a6b8
Author: vabr <vabr@google.com>
Date: Wed May 04 06:53:27 2016
►

Sign in to add a comment