New issue
Advanced search Search tips

Issue 607922 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Fix and re-enable memory.long_running_idle_gmail_tbmv2

Project Member Reported by simonhatch@chromium.org, Apr 29 2016

Issue description

Revision range first seen:
Link to failing step log:

Example: https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf%20%282%29

Pretty much all the windows bots are going purple.


Suspect: https://codereview.chromium.org/1931533002
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2c5f1659cf7b36e1517d41652deccde340fc570

commit a2c5f1659cf7b36e1517d41652deccde340fc570
Author: simonhatch <simonhatch@chromium.org>
Date: Fri Apr 29 15:32:08 2016

Revert of Port memory.long_running_idle_gmail benchmarks to TBMv2. (patchset #6 id:100001 of https://codereview.chromium.org/1931533002/ )

Reason for revert:
All the windows bots going purple, suspect this CL.

BUG= 607922 

Original issue's description:
> Port memory.long_running_idle_gmail benchmarks to TBMv2.
>
> This replaces:
> memory.long_running_idle_gmail_tbm with
> memory.long_running_idle_gmail_tbmv2
> and
> memory.long_running_idle_gmail_background with
> memory.long_running_idle_gmail_background_tbmv2
>
>
> BUG= chromium:593793 
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

TBR=nednguyen@google.com,petrcermak@chromium.org,perezju@chromium.org,ulan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:593793 

Review-Url: https://codereview.chromium.org/1935493003
Cr-Commit-Position: refs/heads/master@{#390656}

[modify] https://crrev.com/a2c5f1659cf7b36e1517d41652deccde340fc570/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/a2c5f1659cf7b36e1517d41652deccde340fc570/tools/perf/benchmarks/memory_infra.py
[modify] https://crrev.com/a2c5f1659cf7b36e1517d41652deccde340fc570/tools/perf/page_sets/long_running_idle_google_cases.py

Owner: u...@chromium.org
Summary: Fix and re-enable memory.long_running_idle_gmail_tbmv2 (was: memory. long_running_idle_gmail_tbmv2 failure on chromium.perf on Windows)
Not sure if this is the error, but I see this:

Sending result 2 of 2 to dashboard.
{... the json .. }
Discarding JSON, error:
HTTPError: 400. Reponse: Non-number found in values list: [2629289325L]
request_id:57227e4200ff0c80fc2fb4f5310001737e6368726f6d657065726600016465762d73756c6c6976616e2d36396136383161650001010c


Comment 3 by u...@chromium.org, Apr 29 2016

Cc: qyears...@chromium.org
qyearsley@, the failing line was introduced in

https://github.com/catapult-project/catapult/commit/e4173cd911586e71c9223453fdf913d9a943e8d5

shouldn't we also check for long() instances here:
https://github.com/catapult-project/catapult/blob/master/dashboard/dashboard/add_point.py#L428 ?
You're right -- the values in the list can also be long values -- that should also be changed to also accept long instances.
Status: Assigned (was: Untriaged)
(https://codereview.chromium.org/1935593002 should fix that)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/497fc81933686d1d031127a618778d49650891a9

commit 497fc81933686d1d031127a618778d49650891a9
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Apr 29 20:34:39 2016

Roll src/third_party/catapult/ 6581f1298..5da225219 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6581f1298785..5da225219728

$ git log 6581f1298..5da225219 --date=short --no-merges --format='%ad %ae %s'

BUG= 607922 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/1937593003
Cr-Commit-Position: refs/heads/master@{#390743}

[modify] https://crrev.com/497fc81933686d1d031127a618778d49650891a9/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449

commit 5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449
Author: ulan <ulan@chromium.org>
Date: Tue May 03 12:04:20 2016

Reland of Port memory.long_running_idle_gmail benchmarks to TBMv2.

The windows bots going purple should be fixed by
https://codereview.chromium.org/1935593002/

This replaces:
memory.long_running_idle_gmail_tbm with
memory.long_running_idle_gmail_tbmv2
and
memory.long_running_idle_gmail_background with
memory.long_running_idle_gmail_background_tbmv2

BUG= 607922 , 593793 
TBR=nednguyen@google.com
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review-Url: https://codereview.chromium.org/1938923002
Cr-Commit-Position: refs/heads/master@{#391205}

[modify] https://crrev.com/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449/tools/perf/benchmarks/memory_infra.py
[modify] https://crrev.com/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449/tools/perf/page_sets/long_running_idle_google_cases.py

Labels: -Pri-1 Pri-2
memory.long_running_idle_gmail_tbmv2 has a successful run in the latest build:

https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf%20%282%29/builds/5427/steps/memory.long_running_idle_gmail_tbmv2

Does that mean that this is fixed? :-)

Comment 9 by u...@chromium.org, May 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment