New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607907 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug


Participants' hotlists:
Autofill-Fixit


Sign in to add a comment

Should not query Autofill server for chrome:// pages

Project Member Reported by ma...@chromium.org, Apr 29 2016

Issue description

Repro: Run chrome with --vmodule=*autofill*=2, see that a query is sent when going to chrome://settings.

I can't think of a reason we would query Autofill (or even use Autofill) from within a chrome:// page.


 
Project Member

Comment 1 by sheriffbot@chromium.org, May 1 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Owner: rogerm@chromium.org
Status: Started (was: Assigned)
Does it make sense to simply validate that the form is at an HTTP(S) origin?

I.e., instead of excluding the chrome scheme, only include http and https schemes?
Cc: se...@chromium.org ma...@chromium.org ftirelo@chromium.org durgapandey@chromium.org nepper@chromium.org dvadym@chromium.org battre@chromium.org
Labels: -Pri-3 -Hotlist-Recharge-Cold OS-Android OS-iOS OS-Windows Pri-2
Does that mean that we would not send queries or votes for address forms that are HTTP?
No, it means we would ONLY send queries and votes for HTTP and HTTPS.
Ahh perfect! I read too fast :)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7300efea63d93b082e780c02b953bd3ed32e9b09

commit 7300efea63d93b082e780c02b953bd3ed32e9b09
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Oct 11 17:37:45 2018

[autofill] Only consider forms from HTTP(S) origins.

Autofill will not query/upload form information for form URLS
having a non HTTP(S) scheme.

Bug:  607907 , 894428
Change-Id: Ic03afbec002e3cf005d22ac25fd96e90b0be1273
Reviewed-on: https://chromium-review.googlesource.com/c/1257184
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598824}
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/form_data_importer_unittest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/password_manager/core/browser/password_form_manager_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment