New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607904 link

Starred by 4 users
Status: Fixed
Owner:
█ fsam...@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ vollick@chromium.org
penghuang@chromium.org
█ markdittmer@chromium.org
rjkroege@chromium.org
vmi...@chromium.org
sadrul@chromium.org
piman@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
mus



Sign in to add a comment

Consolidate traits in gpu/ipc/common

Project Member Reported by fsam...@chromium.org, Apr 29 2016 
Now that ui/gfx/ipc has been decoupled from ui/gfx and thus from skia, it might be possible to consolidate all the traits in gpu/ipc/common:

id_type_traits.h
gpu_command_buffer_traits*
gpu_param_traits*

Also, this trait should move to ui/gfx/ipc/:

IPC_ENUM_TRAITS_MAX_VALUE(gfx::SwapResult, gfx::SwapResult::SWAP_RESULT_LAST)

Once that and ui/latency_info (re)lands, it ought to be possible to consolidate gpu/ipc/common:command_buffer_traits, and gpu/ipc/common into a single target without having to deal with NaCl/Skia dependency issues! FINALLY!
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0b09fb8a875ab0b8ac828980bee325d4a17d657

commit e0b09fb8a875ab0b8ac828980bee325d4a17d657
Author: fsamuel <fsamuel@chromium.org>
Date: Mon May 02 19:35:14 2016

gpu traits: Move gfx::SwapResult trait to ui/gfx/ipc where it belongs

BUG= 607904 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1936103003
Cr-Commit-Position: refs/heads/master@{#391028}

[modify] https://crrev.com/e0b09fb8a875ab0b8ac828980bee325d4a17d657/gpu/ipc/common/gpu_param_traits_macros.h
[modify] https://crrev.com/e0b09fb8a875ab0b8ac828980bee325d4a17d657/ui/gfx/ipc/gfx_param_traits_macros.h
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9589e6383f63504c3e5f6545160beb9ca69984ee

commit 9589e6383f63504c3e5f6545160beb9ca69984ee
Author: fsamuel <fsamuel@chromium.org>
Date: Tue May 03 00:38:18 2016

gpu: consolidate id_type_traits.h and gpu_command_buffer_traits*

BUG= 607904 
TBR=piman@chromium.org for command_buffer_traits.gypi
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1942723003
Cr-Commit-Position: refs/heads/master@{#391124}

[modify] https://crrev.com/9589e6383f63504c3e5f6545160beb9ca69984ee/gpu/command_buffer/common/id_type.h
[modify] https://crrev.com/9589e6383f63504c3e5f6545160beb9ca69984ee/gpu/command_buffer_traits.gypi
[modify] https://crrev.com/9589e6383f63504c3e5f6545160beb9ca69984ee/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/9589e6383f63504c3e5f6545160beb9ca69984ee/gpu/ipc/common/gpu_command_buffer_traits.h
[delete] https://crrev.com/eb09dd790c0ca396ef4a0a8c603ada6eb40ab3a0/gpu/ipc/common/id_type_traits.h

Comment 3 by varkha@chromium.org, Jun 8 2016

Owner: fsam...@chromium.org
Status: Started (was: Untriaged)
Assigning to fsamuel@ since some code is now landed.

Comment 4 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS
Labels: Proj-Mustash

Comment 5 by fsam...@chromium.org, Jan 23 2017

Status: Fixed (was: Started)
This is complete enough to be considered FIXED I think.

Comment 6 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 7 by lafo...@chromium.org, Feb 26 2018

Components: -MUS
►

Sign in to add a comment