New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607875 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

commit queue disregards history information in CLs

Project Member Reported by jochen@chromium.org, Apr 29 2016

Issue description

When uploading a file move with git cl upload --similarty=xxx to preserve history, the file shows up as "A+" in the rietveld UI, but the commit queue will ignore this and instead commit the file as a new file (A) and all history is lost.

e.g. here https://codereview.chromium.org/1920793002
 

Comment 1 by tandrii@google.com, Apr 29 2016

Components: -Build Infra>SDK
Have you tried apply patch locally with apply_issue? A fork of it is used by CQ.
Labels: Infra-DX
Status: Available (was: Untriaged)
Components: -Infra>Git
Cc: iannucci@chromium.org
Status: WontFix (was: Available)
+iannucci@ as Git master who convinced me that:

Git doesn't store renames in history. It merely stores each file's hash and decides on renames/copies only when user asks it to based on two commits (past, current). This means that --similarity=xxx isn't anyhow reflected this in git's history.
Good explanation http://stackoverflow.com/a/21082870

So, while I now understand what you want, Jochen, I think this as WontFix as it can't be done with git.

Sign in to add a comment