New issue
Advanced search Search tips

Issue 607868 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Spec change: Remove <label form> and redefine label.form IDL attribute

Reported by sim...@opera.com, Apr 29 2016

Issue description

label.form IDL attribute should be an alias for label.control.form.
<label form> content attribute should have no effect.

Spec change
https://github.com/whatwg/html/pull/1120

Tests
https://github.com/w3c/web-platform-tests/pull/2926
 

Comment 1 by tkent@chromium.org, May 1 2016

Components: -Blink>HTML Blink>Forms>Label
Labels: Hotlist-Interop
Status: Available (was: Untriaged)
Note: Intent-to-implement-and-ship is necessary.

Comment 2 by sim...@opera.com, May 13 2016

(Tests reviewed and merged in w-p-t now.)

Comment 3 by tkent@chromium.org, May 25 2016

Cc: -tkent@chromium.org
Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be

commit 5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be
Author: tkent <tkent@chromium.org>
Date: Thu May 26 08:30:22 2016

Drop LABEL element from form-associated elements.

- Remove 'form' content attribute support from LABEL element
- 'form' IDL attribute returns the value of label.control.form.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/QWyCpJjgfY8/TOxG9n-OAQAJ

BUG= 607868 

Review-Url: https://codereview.chromium.org/2000423006
Cr-Commit-Position: refs/heads/master@{#396149}

[delete] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/form/test1-expected.txt
[delete] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/form/test1.html
[delete] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/label-formAssociatedElement-expected.txt
[delete] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/label-formAssociatedElement.html
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/LayoutTests/fast/forms/form-associated-element-expected.txt
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/LayoutTests/fast/forms/form-associated-element.html
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/LayoutTests/fast/forms/form-attribute-expected.txt
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/LayoutTests/fast/forms/form-attribute-nonexistence-form-id-expected.txt
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/LayoutTests/fast/forms/form-attribute-nonexistence-form-id.html
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/LayoutTests/fast/forms/form-attribute.html
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/form-control-infrastructure/form-expected.txt
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-label-element/label-attributes-expected.txt
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/FormAssociatedElement.cpp
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/FormAssociatedElement.h
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/HTMLLabelElement.h
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/HTMLLabelElement.idl
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/HTMLObjectElement.h
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/HTMLTagNames.in
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/LabelsNodeList.cpp
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be/third_party/WebKit/Source/web/WebLabelElement.cpp

Comment 5 by tkent@chromium.org, May 26 2016

Labels: M-53
Status: Fixed (was: Started)

Sign in to add a comment