New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607852 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Unwanted Slideshow button is seen in gallery when no image is present

Project Member Reported by sc00335...@techmahindra.com, Apr 29 2016

Issue description

Version: 52.0.2719.0/8255.0.0 (Official Build) dev-channel daisy,peppy,mighty,gnawty
OS: Chrome os

What steps will reproduce the problem?
(1) Open any image in gallery[Slide view] >> Delete that image >> Hit right/up/down arrow from keyboard and observe

Expected: "Slideshow" icon should not be seen when no images are present.
Actual: Unnecessary "Slideshow" icon is seen on using those arrow keys.

This is a non-regression issues as it is also seen in 49.0.2623.112/7834.70.0 (Official Build) stable-channel daisy.

@yawano: Please confirm the issue.
 
Actual.png
812 KB View Download
Able to reproduce the issue on Peppy using chrome version 52.0.2719.0/8255.0.0
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 11 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0197e54830c124fa205bb206959cb284c81ad39f

commit 0197e54830c124fa205bb206959cb284c81ad39f
Author: harukam <harukam@google.com>
Date: Wed Aug 10 06:50:38 2016

Fix index changed when no image in the directory in gallery

BUG= 607852 
TEST=manually tested

Review-Url: https://codereview.chromium.org/2229733002
Cr-Commit-Position: refs/heads/master@{#410986}

[modify] https://crrev.com/0197e54830c124fa205bb206959cb284c81ad39f/ui/file_manager/gallery/js/slide_mode.js

Owner: harukam@chromium.org
Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 7 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)

Sign in to add a comment