New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607844 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature


Sign in to add a comment

Allow users to mirror desktop across 3+ monitors

Reported by jimmy_y...@quantatw.com, Apr 29 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.112 Safari/537.36
Platform: 7978.66.0 (official Build) dev-channel sentry test

Steps to reproduce the problem:
1. Power on chromebook which contain at least two type c ports.
2. Plug two type c to HDMI/VGA/DP cables then connect with external monitors.
3. Display mode is under extended mode when 3 display active
4. Press ctrl + F4 or display setting  to change display mode , find it cannot be changed

What is the expected behavior?
Display mode can be changed bwtween extend/clone when 3 display active

What went wrong?
Display setting cannott be changed when 3 display active

Did this work before? No 

Chrome version: 50.0.2661.91  Channel: dev
OS Version: 7978.66.0
Flash Version:
 
Screenshot.png
2.9 MB View Download

Comment 1 by tbroch@chromium.org, Apr 29 2016

Cc: tbroch@chromium.org
Labels: -Type-Bug Type-Feature
Owner: abodenha@chromium.org
Status: Untriaged (was: Unconfirmed)
Cc: tbuck...@chromium.org osh...@chromium.org
Owner: tbuck...@chromium.org
Status: Assigned (was: Untriaged)
We should DEFINITELY not be showing the "dear monitor" message here. I've filed  bug 608027  to track that.

The key question is are there there enough users who want this to justify its creation?

Trying to figure out how to do this in a performant way would be tricky.
Hi Google team,
Sentry unit contain 2 type c ports.
we cannot avoid end-user output their screen to external monitors via 2 type c cables.
while perform a presentation with 2 external monitors, clone mode is more useful then extend mode.
current image cannot support clone mode and display mode switch may cause confusion of end-user

Comment 4 by r...@chromium.org, Jul 21 2017

Components: -UI UI>Shell>MultipleMonitor
Cc: steve...@chromium.org
Owner: osh...@chromium.org
@oshima do we have plans to support mirroring across 2 external displays? If not, we should disable the ability to do that in Settings.

Comment 6 by osh...@chromium.org, Jul 27 2017

Owner: afakhry@chromium.org
I thought this is already disabled in settings, and shortcut is ignored.

stevenjb@, afakhry@, what's the current status?
'Mirroring' is only shown in the UI when there are 2 displays (i.e. 1 external display).

Was there something else that needs to be disabled in the UI with 3+ displays?

It seems that this bug is a feature request to support mirroring from 3+ displays. Am I correct?
Cc: ovanieva@chromium.org
Summary: Allow users to mirror desktop across 3+ monitors (was: Display mode cannot be changed when 3 display active)
Yes, if we aren't exposing it to users then this issue is only about supporting it for 3+ displays. Updating the title and adding in ovanieva for multi-display.
Cc: abodenha@chromium.org kuscher@chromium.org afakhry@chromium.org
 Issue 589319  has been merged into this issue.
Cc: weidongg@chromium.org
Blocking: 773401
Blockedon: 773401
Blocking: -773401 774794
Labels: Multi-Display-Mirroring
Blockedon: 772457
Cc: -weidongg@chromium.org
Owner: weidongg@chromium.org
Blockedon: 776442
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bafe78889d58613c2aaae534d5154840fb66b995

commit bafe78889d58613c2aaae534d5154840fb66b995
Author: Weidong Guo <weidongg@chromium.org>
Date: Tue Oct 31 17:44:16 2017

multi-display-mirroring: Prerequisite clean up

This CL is a prerequisite CL for supporting mirroring across 3+
displays.
Changes:
1. Clean up old code of mirror mode in display manager and make software
and hardware mirroring more intuitive.
2. Fix a bug that misuses mirroring destination display as source in
display_info_provider_chromeos.cc

Design doc:
go/multi-display-mirroring

BUG= 607844 

Change-Id: I38a065e2693c1094d9b460dd99ad0b2daabd0215
Reviewed-on: https://chromium-review.googlesource.com/734799
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512867}
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/display/mirror_window_controller.h
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/display/mirror_window_controller_unittest.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/display/mirror_window_test_api.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/display/mirror_window_test_api.h
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ui/display/manager/chromeos/display_configurator.h
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ui/display/manager/display_manager.cc
[modify] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/ui/display/manager/display_manager.h

Blockedon: 782291
Blockedon: 782292
Blockedon: 782511
Blockedon: 782512
Blockedon: 784516
Blockedon: 784623
Blockedon: 785070
Blockedon: 785416
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92aa97948dbf94c5316014b00d7652f2e644e4e8

commit 92aa97948dbf94c5316014b00d7652f2e644e4e8
Author: Weidong Guo <weidongg@chromium.org>
Date: Thu Nov 16 05:08:49 2017

multi-display-mirroring: Implement hardware mirroring

Changes:
1. Support hardware mirroring by adding function to find/create mirror
   mode for 2+ displays.
2. Add unit tests.

Design doc:
go/multi-display-mirroring

BUG= 607844 
TEST=DisplayConfiguratorTest.*

Change-Id: If3371fcfa66b6c5a121a1f1401085df777638b4e
Reviewed-on: https://chromium-review.googlesource.com/731658
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516995}
[modify] https://crrev.com/92aa97948dbf94c5316014b00d7652f2e644e4e8/ui/display/manager/chromeos/display_configurator.cc
[modify] https://crrev.com/92aa97948dbf94c5316014b00d7652f2e644e4e8/ui/display/manager/chromeos/display_configurator.h
[modify] https://crrev.com/92aa97948dbf94c5316014b00d7652f2e644e4e8/ui/display/manager/chromeos/display_configurator_unittest.cc

Status: Fixed (was: Assigned)
Blockedon: 790720

Comment 30 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 31 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment