New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607841 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

MediaSourceTest.Playback_Video_MP4_Audio_WEBM is flaky on Android.

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 29 2016

Issue description

"content_browsertests" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRjb250ZW50X2Jyb3dzZXJ0ZXN0cww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 604112 .
 
Cc: dalecur...@chromium.org
Components: Internals>Media
Labels: -Sheriff-Chromium
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
Yup, looks flaky to me.

@dalecurtis, can you find an owner for this and/or fix or disable the test?
Cc: ti...@chromium.org wolenetz@chromium.org
Components: -Internals>Media Internals>Media>Source
Labels: Proj-Spitzer OS-Android
Owner: chcunningham@chromium.org
Summary: MediaSourceTest.Playback_Video_MP4_Audio_WEBM is flaky on Android. (was: "content_browsertests" is flaky)
First bad run: "try run at 2016-04-28 15:57:29 UTC", associated patchset looks unrelated: https://codereview.chromium.org/1895293002/#ps100001

The test in question:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/media/media_source_browsertest.cc&l=109
Disable for android is in CQ now
https://codereview.chromium.org/1931023004/
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/298b944c5bb9e6960b9aca572d8fb9987d5355f8

commit 298b944c5bb9e6960b9aca572d8fb9987d5355f8
Author: chcunningham <chcunningham@chromium.org>
Date: Fri Apr 29 21:58:53 2016

Disable flaky MediaSourceTest.Playback_Video_MP4_Audio_WEBM on Android.

BUG= 607841 

Review-Url: https://codereview.chromium.org/1931023004
Cr-Commit-Position: refs/heads/master@{#390775}

[modify] https://crrev.com/298b944c5bb9e6960b9aca572d8fb9987d5355f8/content/browser/media/media_source_browsertest.cc

Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Apr 30 2016

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "content_browsertests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRjb250ZW50X2Jyb3dzZXJ0ZXN0cww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, May 2 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "content_browsertests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRjb250ZW50X2Jyb3dzZXJ0ZXN0cww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Hmm, these new flakes are not media failures. dpranke@ can we get the sheriff bot to file a new bug?
Labels: -Sheriff-Chromium
Yeah, the bot seems to be buggy (I've been discussing this w/ the infra folks elsewhere).

Comment 10 Deleted

Comment 11 Deleted

Labels: MSEsrubbed
dpranke@, re: comment 9, how is the infra doing? Shall I re-enable the test?
Cc: chcunningham@chromium.org dpranke@chromium.org
Labels: -Pri-1 M-70 Pri-2
Owner: wolenetz@chromium.org
Status: Started (was: Assigned)
Hmm. Scanning MSE P0/P1 SLO violations, this P1 has been sitting too long => empirically not P1.

Since Chris is otherwise occupied, I'm going to speculatively un-DISABLE content_browsertest: MediaSourceTest.Playback_Video_MP4_Audio_WEBM on Android.

On platforms where that test has been running recently (mac/windows bots with proprietary codecs in their build config), this test hasn't been flaky.
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b144a3288f69633b553f627b94155d70d0ff6ec

commit 2b144a3288f69633b553f627b94155d70d0ff6ec
Author: Matt Wolenetz <wolenetz@chromium.org>
Date: Mon Aug 06 19:08:35 2018

MSE: Enable content_browsertests:MediaSourceTest.Playback_Video_MP4_Audio_WEBM on Android

On Android, this test was flaky and was disabled on Android over 2 years ago.
This change speculatively re-enables the test on Android.

BUG= 607841 

Change-Id: I21acef884055bfb321dce17f4ca83803becd8ced
Reviewed-on: https://chromium-review.googlesource.com/1162915
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580943}
[modify] https://crrev.com/2b144a3288f69633b553f627b94155d70d0ff6ec/content/browser/media/media_source_browsertest.cc

Status: Fixed (was: Started)
So far, runs are starting to pass: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=Playback_Video_MP4_Audio_WEBM

I also reset the "Current Issue ID" to 0 for content_browsertests at chromium-try-flakes.appspot.com, since I've closed crbug 607841. New flakes should file a new bug, IIUC.

Sign in to add a comment