New issue
Advanced search Search tips

Issue 607817 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 607818



Sign in to add a comment

Add running debug mode perf tests while running trybots for commit and dryrun.

Project Member Reported by prashan...@samsung.com, Apr 29 2016

Issue description

Currently the debug mode perftests are not run by any trybot, which leaves errors in perftests.

e.g. If I run ./out/Debug/cc_perftests, it crashes many places.

Having them run by bots, will help make perftests more correct.
 
Blockedon: 607818
Cc: danakj@chromium.org

Comment 3 by danakj@chromium.org, May 18 2016

Is there ever a reason to run perftests in debug? They are for measuring performance. If you want to guard bugs, use a unit test?
This is just for checking whether our perf tests are okay and maintains the logic/semantics of our implementation. Running perf tests which crash in debug mode, might be doing little wrong, different from what is actually expected, which I think we should prevent by adding to trybots.

For performance measurement, we'll keep using release mode perf tests.

Sign in to add a comment