New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607807 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"taskkill" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 29 2016

Issue description

"taskkill" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyEwsSBUZsYWtlIgh0YXNra2lsbAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: wfh@chromium.org scottmg@chromium.org thakis@chromium.org mar...@chromium.org brucedaw...@chromium.org
Components: Infra>CQ Infra
Labels: -Sheriff-Chromium
odd ... cc'ed folks, any idea why this might be flaky or failing?

Comment 2 by wfh@chromium.org, Apr 29 2016

dunno maybe the tasks are dying by themselves before they can be killed and that's returning a '1'. perhaps just wrapping the script to ignore failures of these type?
That's odd, it looks like it's flaking in this loop https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/kill_processes.py&l=27 . But I don't see anything (running tasklist or taskkill) that would make it abort and return 1 to the system.

And it says it ran in 0sec so I assume it's not timing out https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/205218/steps/taskkill/logs/stdio .

I wonder if it's possible if some Log()s aren't making it?
Components: -Infra
Owner: phajdan.jr@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3cd8f14b0891aba2f3bd1bf61506f5636f71217d

commit 3cd8f14b0891aba2f3bd1bf61506f5636f71217d
Author: phajdan.jr@chromium.org <phajdan.jr@chromium.org>
Date: Thu May 05 09:18:43 2016

build: mark taskkill as an infra step

BUG= 607807 

Review-Url: https://codereview.chromium.org/1945323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300452 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/3cd8f14b0891aba2f3bd1bf61506f5636f71217d/scripts/slave/recipe_modules/chromium/api.py

Project Member

Comment 7 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87446

------------------------------------------------------------------
r87446 | recipe-roller@chromium.org | 2016-05-05T09:23:09.105958Z

-----------------------------------------------------------------
Pawel, what else needs to be done here? Can we close this?
Components: -Infra>CQ Infra>Client>Chrome
Status: Fixed (was: Assigned)

Sign in to add a comment