Line heights aren't implemented |
||||||||
Issue descriptionPlease see typography section at the bottom of spec for line heights information. Spec is here: https://folio.googleplex.com/chrome-ux/mocks/335-NTP-Zine/Zine/_UI%20Review/spec#%2FSpec%20-%20zine.png
,
May 2 2016
,
May 3 2016
,
May 5 2016
,
May 6 2016
I'll defer to Alan on the final details here.
,
May 9 2016
,
May 11 2016
Fantastic
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/916492e02a7ee04834f260c2e58d01c17f823b85 commit 916492e02a7ee04834f260c2e58d01c17f823b85 Author: peconn <peconn@chromium.org> Date: Wed May 11 09:53:26 2016 Create TextViewWithLeading. Create an extension of the TextView class that performs the calculations necessary to set the text leading in XML. The calculation was taken from go/md-text-reco. BUG= 607803 Review-Url: https://codereview.chromium.org/1955813002 Cr-Commit-Position: refs/heads/master@{#392888} [modify] https://crrev.com/916492e02a7ee04834f260c2e58d01c17f823b85/chrome/android/java/res/layout/new_tab_page_snippets_card.xml [modify] https://crrev.com/916492e02a7ee04834f260c2e58d01c17f823b85/ui/android/BUILD.gn [modify] https://crrev.com/916492e02a7ee04834f260c2e58d01c17f823b85/ui/android/java/res/values/attrs.xml [add] https://crrev.com/916492e02a7ee04834f260c2e58d01c17f823b85/ui/android/java/src/org/chromium/ui/widget/TextViewWithLeading.java
,
May 16 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by treib@chromium.org
, May 2 2016