New issue
Advanced search Search tips

Issue 607779 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: surface parsed manifest info in resources panel.

Project Member Reported by pfeldman@chromium.org, Apr 29 2016

Issue description

We should at least surface errors and theme color.

Mocks to follow.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727

commit d9e2f6578d27b98d379ea9abb5bbf4d1b630b727
Author: pfeldman <pfeldman@chromium.org>
Date: Fri Apr 29 20:58:10 2016

DevTools: Introduce Page.getManifest remote debugging protocol method.

BUG= 607779 

Review-Url: https://codereview.chromium.org/1932623003
Cr-Commit-Position: refs/heads/master@{#390754}

[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/content_renderer.gypi
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/devtools/devtools_agent.h
[add] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/manifest/manifest_debug_info.cc
[add] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/manifest/manifest_debug_info.h
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/push_messaging/push_messaging_dispatcher.cc
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/content/renderer/push_messaging/push_messaging_dispatcher.h
[modify] https://crrev.com/d9e2f6578d27b98d379ea9abb5bbf4d1b630b727/third_party/WebKit/Source/devtools/protocol.json

manifest.png
53.4 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6316e6882ce8682f2d0f8a895dc99688962a2645

commit 6316e6882ce8682f2d0f8a895dc99688962a2645
Author: pfeldman <pfeldman@chromium.org>
Date: Sat Apr 30 02:35:44 2016

DevTools: render parsed manifest data in the resources panel.

BUG= 607779 

Review-Url: https://codereview.chromium.org/1942523002
Cr-Commit-Position: refs/heads/master@{#390837}

[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/devtools.gypi
[add] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
[add] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/resources/appManifestView.css
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/resources/module.json
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/security/originView.css
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
[modify] https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645/third_party/WebKit/Source/devtools/protocol.json

Status: Fixed (was: Assigned)

Sign in to add a comment