New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607751 link

Starred by 2 users
Status: Fixed
Owner:
█ xyzzyz@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
kcc@chromium.org
█ xyzzyz@chromium.org
█ krasin@chromium.org
p...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update third_party/protobuf to pull offsetof changes

Project Member Reported by krasin@chromium.org, Apr 28 2016 
Recently, I have submitted a local patch into //third_party/protobuf that uses __builtin_offsetof instead of invalid reinterpret_casts if Clang is the compiler: https://codereview.chromium.org/1929193002/

Slightly before that, I have submitted a similar change into the internal Google repo. These changes should reach github in 2-3 weeks from now, if everything goes smooth.

This issue is to track the movement of these patches and to remove the local patch when the official fix is available on github.

Comment 3 by xyzzyz@chromium.org, May 16 2016 

I see the new version of protobuf was released just two hours ago: https://github.com/google/protobuf/releases

Does it include your changes? If so, I'll update third_party/protobuf to the new version, and remove your local patches.

Comment 4 by krasin@chromium.org, May 16 2016 

Yes, it does:

krasin@krasin2:/tmp/proto-check/protobuf-3.0.0-beta-3$ ag 'clang diagnostic push' src
src/google/protobuf/api.pb.cc
1001:  _Pragma("clang diagnostic push") \

src/google/protobuf/compiler/objectivec/objectivec_file.cc
118:      "#pragma clang diagnostic push\n"
225:      "#pragma clang diagnostic push\n"

src/google/protobuf/timestamp.pb.cc
199:  _Pragma("clang diagnostic push") \

src/google/protobuf/compiler/cpp/cpp_message.cc
2397:      "  _Pragma(\"clang diagnostic push\") \\\n"

src/google/protobuf/duration.pb.cc
185:  _Pragma("clang diagnostic push") \

src/google/protobuf/generated_message_reflection.h
590:  _Pragma("clang diagnostic push")                            \

src/google/protobuf/type.pb.cc
1121:  _Pragma("clang diagnostic push") \

src/google/protobuf/descriptor.pb.cc
2496:  _Pragma("clang diagnostic push") \
2795:  _Pragma("clang diagnostic push") \
7182:  _Pragma("clang diagnostic push") \
7994:  _Pragma("clang diagnostic push") \
9397:  _Pragma("clang diagnostic push") \
10006:  _Pragma("clang diagnostic push") \
10698:  _Pragma("clang diagnostic push") \
12534:  _Pragma("clang diagnostic push") \
14407:  _Pragma("clang diagnostic push") \

Thank you for offering to update the protobuf version!

Comment 5 by xyzzyz@chromium.org, May 16 2016 

OK, I'll start working on an update -- I'd have done it anyway, as it also adds protobuf lite support for proto3 :)

Comment 6 by krasin@chromium.org, May 16 2016 

Thx!

Comment 7 by krasin@chromium.org, May 17 2016

Owner: xyzzyz@chromium.org
Reassigning the bug to match reality and formality.

Comment 8 by xyzzyz@chromium.org, May 17 2016 

Work is in progress. The release is a bit buggy (https://github.com/google/protobuf/pull/1549, https://github.com/google/protobuf/pull/1547)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90

commit a5b3d51ac5c84564b9671fbdb6afb54a527ebd90
Author: xyzzyz <xyzzyz@chromium.org>
Date: Thu Jun 02 19:58:00 2016

Update third_party/protobuf to protobuf-v3.0.0-beta-3

This is a minor update that incorporates some of our local patches. It also
introduces lite support for proto3 language.

It also incorporates a patch that reduces amount of memory
used by proto messages, at a cost of increased binary size.

For mobile, the binary size grows by ~20 KB with significant memory usage reduction:

http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-27_17-22-13

For desktop, the binary size grows by ~200 KB with similar reduction.

BUG= 607751 

Review-Url: https://codereview.chromium.org/1983203003
Cr-Commit-Position: refs/heads/master@{#397491}

[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/.gitignore
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/.travis.yml
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/BUILD
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/BUILD.gn
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/CHANGES.txt
[delete] https://crrev.com/c34f049e6f49920680eb5634502b22511d7e03f9/third_party/protobuf/INSTALL.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/Makefile.am
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/Protobuf.podspec
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/README.chromium
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/README.md
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/WORKSPACE
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/benchmarks/Makefile.am
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/benchmarks/README.md
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/benchmarks/benchmark_messages_proto2.proto
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/benchmarks/benchmark_messages_proto3.proto
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/benchmarks/benchmarks.proto
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/benchmarks/generate_datasets.cc
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/cmake/CMakeLists.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/cmake/README.md
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/cmake/libprotoc.cmake
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/cmake/tests.cmake
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/configure.ac
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/ConformanceJava.java
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/ConformanceJavaLite.java
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/Makefile.am
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/conformance_objc.m
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/conformance_ruby.rb
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/conformance_test.cc
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/conformance_test_runner.cc
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/failure_list_cpp.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/failure_list_csharp.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/failure_list_java.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/failure_list_objc.txt
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/failure_list_python-post26.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/failure_list_python.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/failure_list_python_cpp.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/conformance/failure_list_ruby.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/.gitignore
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/CHANGES.txt
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/Google.Protobuf.Tools.nuspec
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/README.md
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/generate_protos.sh
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/keys/Google.Protobuf.snk
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/keys/README.md
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/protos/unittest_issues.proto
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/AddressBook/AddPerson.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/AddressBook/Addressbook.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/AddressBook/ListPeople.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/Conformance.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/Program.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/CodedInputStreamTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/CodedOutputStreamTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/Collections/MapFieldTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/GeneratedMessageTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/Google.Protobuf.Test.csproj
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/IssuesTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonFormatterTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonParserTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonTokenizerTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/Reflection/DescriptorsTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/Reflection/FieldAccessTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/SampleMessages.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestCornerCases.cs
[copy] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/ForeignMessagePartial.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/MapUnittestProto3.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestImportProto3.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestImportPublicProto3.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestIssues.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestProto3.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestWellKnownTypes.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/AnyTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/DurationTest.cs
[copy] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/FieldMaskTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/TimestampTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/WrappersTest.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/CodedInputStream.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/CodedOutputStream.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Collections/MapField.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Collections/RepeatedField.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/FieldCodec.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Google.Protobuf.csproj
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Google.Protobuf.nuspec
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/ICustomDiagnosticMessage.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/InvalidProtocolBufferException.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/JsonFormatter.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/JsonParser.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/MessageExtensions.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/MessageParser.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Properties/AssemblyInfo.cs
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/ProtoPreconditions.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/Descriptor.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/FieldDescriptor.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/FileDescriptor.cs
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/GeneratedClrTypeInfo.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/MessageDescriptor.cs
[copy] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/OriginalNameAttribute.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/TypeRegistry.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Any.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/AnyPartial.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Api.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Duration.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/DurationPartial.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Empty.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/FieldMask.cs
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/FieldMaskPartial.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/SourceContext.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Struct.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Timestamp.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/TimestampPartial.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Type.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/ValuePartial.cs
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Wrappers.cs
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/docs/swift/DesignDoc.md
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/docs/third_party.md
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/examples/README.txt
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/examples/add_person.py
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/examples/list_people.py
[modify] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/generate_descriptor_proto.sh
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/generate-sources-build.xml
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/generate-test-sources-build.xml
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/pom.xml
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/AbstractMessage.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/AbstractMessageLite.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/AbstractParser.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/AbstractProtobufList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/BlockingRpcChannel.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/BlockingService.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/BooleanArrayList.java
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ByteBufferWriter.java
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ByteOutput.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ByteString.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/CodedInputStream.java
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/CodedOutputStream.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/Descriptors.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/DoubleArrayList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/DynamicMessage.java
[copy] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ExperimentalApi.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/Extension.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ExtensionLite.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ExtensionRegistry.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ExtensionRegistryLite.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/FieldSet.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/FloatArrayList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/GeneratedMessage.java
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/GeneratedMessageLite.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/IntArrayList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/Internal.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/InvalidProtocolBufferException.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/LazyField.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/LazyFieldLite.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/LazyStringArrayList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/LazyStringList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/LongArrayList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MapEntry.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MapEntryLite.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MapField.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MapFieldLite.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/Message.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MessageLite.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MessageLiteOrBuilder.java
[add] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MessageLiteToString.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MessageOrBuilder.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MessageReflection.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/MutabilityOracle.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/NioByteString.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/Parser.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ProtobufArrayList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ProtocolMessageEnum.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/ProtocolStringList.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/RepeatedFieldBuilder.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core/src/main/java/com/google/protobuf/RopeByteString.java
[rename] https://crrev.com/a5b3d51ac5c84564b9671fbdb6afb54a527ebd90/third_party/protobuf/java/core

Comment 10 by xyzzyz@chromium.org, Jun 6 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment