New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607748 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 635948



Sign in to add a comment

DevTools: command line API is unavailable in worker context

Project Member Reported by kozyatinskiy@chromium.org, Apr 28 2016

Issue description

It's available only in context with window global.
 
Cc: dgozman@chromium.org
 Issue 614668  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bba4159d276c9513d8ba25d742ceb32a0c8075e

commit 3bba4159d276c9513d8ba25d742ceb32a0c8075e
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Jun 13 21:53:35 2016

[DevTools] Support CommandLineAPI in workers and Node.js

CommandLineAPI injection is moved to v8_inspector in this CL. CommandLineAPI methods are installed to global object as non enumerable, replaceble properties. Method can be overriden during evaluation and doesn't override existing property if it's presented.

BUG= 607748 , 595206 
R=dgozman@chromium.org, pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2030453002
Cr-Commit-Position: refs/heads/master@{#399560}

[add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api-expected.txt
[add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api.html
[add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-command-line-api-can-be-overriden-expected.txt
[add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-command-line-api-can-be-overriden.html
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bba4159d276c9513d8ba25d742ceb32a0c8075e

commit 3bba4159d276c9513d8ba25d742ceb32a0c8075e
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Jun 13 21:53:35 2016

[DevTools] Support CommandLineAPI in workers and Node.js

CommandLineAPI injection is moved to v8_inspector in this CL. CommandLineAPI methods are installed to global object as non enumerable, replaceble properties. Method can be overriden during evaluation and doesn't override existing property if it's presented.

BUG= 607748 , 595206 
R=dgozman@chromium.org, pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2030453002
Cr-Commit-Position: refs/heads/master@{#399560}

[add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api-expected.txt
[add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api.html
[add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-command-line-api-can-be-overriden-expected.txt
[add] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-command-line-api-can-be-overriden.html
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
[modify] https://crrev.com/3bba4159d276c9513d8ba25d742ceb32a0c8075e/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Status: Fixed (was: Assigned)
Blocking: 635948

Sign in to add a comment