New issue
Advanced search Search tips

Issue 607742 link

Starred by 1 user
Status: Verified
Owner:
alemate@chromium.org
Closed: Apr 2016
Cc:
abodenha@chromium.org
steve...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SimpleGeolocationRequest has circular dependency

Project Member Reported by osh...@chromium.org, Apr 28 2016 
I'm trying to add include check to chromeos (https://codereview.chromium.org/1927133003/)
and found the following circular dependency.

SimpleGeolocationRequest(chromeos) -> SimpleGeolocationRequestTestMonitor (chromeos:test_support) -> chromeos

It's added in https://codereview.chromium.org/1819173002. alemate@, can you work on a fix?

Comment 1 by alemate@chromium.org, Apr 29 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bd0a2304a53074ff1c76b6b82f7c68ec55a06a2

commit 3bd0a2304a53074ff1c76b6b82f7c68ec55a06a2
Author: alemate <alemate@chromium.org>
Date: Fri Apr 29 17:29:52 2016

ChromeOS: chromeos should not depend on chromeos_test_support.

This Cl removes undesired chromeos build dependency on chromeos_test_support.

BUG= 607742 
TEST=none

Review-Url: https://codereview.chromium.org/1933003003
Cr-Commit-Position: refs/heads/master@{#390685}

[modify] https://crrev.com/3bd0a2304a53074ff1c76b6b82f7c68ec55a06a2/chromeos/BUILD.gn
[modify] https://crrev.com/3bd0a2304a53074ff1c76b6b82f7c68ec55a06a2/chromeos/chromeos.gyp
[modify] https://crrev.com/3bd0a2304a53074ff1c76b6b82f7c68ec55a06a2/chromeos/geolocation/simple_geolocation_request_test_monitor.h

Comment 3 by alemate@chromium.org, Apr 30 2016

Status: Fixed (was: Started)

Comment 4 by patricia@chromium.org, May 23 2016 

Bulk verified

Comment 5 by patricia@chromium.org, May 23 2016

Status: Verified (was: Fixed)
bulk verified
►

Sign in to add a comment