New issue
Advanced search Search tips

Issue 607738 link

Starred by 2 users
Status: Fixed
Owner:
se...@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

PersonalDataManager::OverwriteWith should be case sensitive.

Project Member Reported by se...@chromium.org, Apr 28 2016 
The comment for the function and the comment preceding the function calls say that it is suppose to overwrite every field.

The case insensitive comparison is useful to check if the profiles are similar. It is not the case for the overwrite.

When I made the change to support punctuation a while back, we decided that we should always keep the latest version entered by the user. That way the behavior is previsible to the user. This is already how it works for punctuation and it should be the same for case.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bc61dd282133e1c333e3998b726621455f509dd

commit 2bc61dd282133e1c333e3998b726621455f509dd
Author: sebsg <sebsg@chromium.org>
Date: Wed May 04 13:43:34 2016

That way Autofill always keeps the latest "syntax" that the user used for each field.

Also added a couple of other merge tests.

BUG= 607738 
TEST=ContactInfoTest, AutofillMergeTest

Review-Url: https://codereview.chromium.org/1931123002
Cr-Commit-Position: refs/heads/master@{#391496}

[modify] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/autofill/core/browser/autofill_profile.h
[modify] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/autofill/core/browser/autofill_profile_unittest.cc
[modify] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/autofill/core/browser/contact_info.cc
[modify] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/autofill/core/browser/contact_info.h
[modify] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/autofill/core/browser/contact_info_unittest.cc
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/input/addressLinesLessInfo.in
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/input/addressLinesMoreInfo.in
[modify] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/input/case.in
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/input/moreInfo.in
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/input/names.in
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/input/punctuation.in
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/output/addressLinesLessInfo.out
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/output/addressLinesMoreInfo.out
[modify] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/output/case.out
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/output/moreInfo.out
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/output/names.out
[add] https://crrev.com/2bc61dd282133e1c333e3998b726621455f509dd/components/test/data/autofill/merge/output/punctuation.out

Comment 2 by se...@chromium.org, May 4 2016

Status: Fixed (was: Started)
►

Sign in to add a comment