New issue
Advanced search Search tips

Issue 607733 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 607699

Blocking:
issue 607711



Sign in to add a comment

Add histogram for Biquad Q values

Project Member Reported by rtoy@chromium.org, Apr 28 2016

Issue description

The BiquadFilter node is changing the formulas for the lowpass and highpass filters.  The basic affect is that the Q value of the filter produces different filter responses now.  From some experiments, we know that Q values above 5 or so have only small audio changes.  Smaller values, however, have easily noticeable changes in audio.

To understand how much this change might affect existing applications, it would be useful to have a histogram of the Q values in use. 

This is a bit complicated because the AudioParam object doesn't know what it is being used for and because the Q AudioParam is used for all 7 filter types.  We only want a histogram for the lowpass (and highpass) filters.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d01806ab92e8a360d5dd468cec1d4e91a79d6c6

commit 2d01806ab92e8a360d5dd468cec1d4e91a79d6c6
Author: rtoy <rtoy@chromium.org>
Date: Tue May 10 18:00:02 2016

Add histograms for Biquad lowpass and highpass Q values

This is to measure the Q values in common use so we can determine how
much impact there will be if the BiquadFilter changes the internal
formulas for the lowpass and highpass filters.

BUG= 607733 
TEST=none

Review-Url: https://codereview.chromium.org/1934683002
Cr-Commit-Position: refs/heads/master@{#392643}

[modify] https://crrev.com/2d01806ab92e8a360d5dd468cec1d4e91a79d6c6/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/2d01806ab92e8a360d5dd468cec1d4e91a79d6c6/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/2d01806ab92e8a360d5dd468cec1d4e91a79d6c6/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/2d01806ab92e8a360d5dd468cec1d4e91a79d6c6/tools/metrics/histograms/histograms.xml

Comment 2 by rtoy@chromium.org, May 12 2016

Owner: rtoy@chromium.org
Status: Verified (was: Available)
Histograms are available now.

Comment 3 by rtoy@chromium.org, May 16 2016

Blocking: 607711

Sign in to add a comment