x509_certificate_model.h shouldn't be included from non Linux/ChromeOS platforms |
|||
Issue descriptionThis file shouldn't be compiled on all platforms as it only supports one of USE_NSS_CERTS or USE_OPENSSL_CERTS.
,
Apr 28 2016
Build-restricting it SGTM. Yeah, it doesn't seem useful outside of Linux/CrOS. We also can probably take the USE_OPENSSL_CERTS one out of there. Nothing builds it at all.
,
Apr 29 2016
Where is it being included on non-linux/chromeos platforms? Or do you just mean that it's not removed from the sources list in gyp/gn? Does listing a .h in sources do anything if nothing includes it?
,
Apr 29 2016
Oh, I guess it's because x509_certificate_model.cc isn't removed. BTW, https://codereview.chromium.org/1893203005/ is going to clean up some of the USE_OPENSSL_CERTS stuff there.
,
Jun 21 2016
,
Mar 16 2018
This got done during the use_byte_certs work. https://chromium.googlesource.com/chromium/src/+/381b177ce7cb2df33e1f02c1939d97af7acc2640 |
|||
►
Sign in to add a comment |
|||
Comment 1 by rsleevi@chromium.org
, Apr 28 2016