New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607714 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

x509_certificate_model.h shouldn't be included from non Linux/ChromeOS platforms

Project Member Reported by mea...@chromium.org, Apr 28 2016

Issue description

This file shouldn't be compiled on all platforms as it only supports one of USE_NSS_CERTS or USE_OPENSSL_CERTS.
 
Cc: svaldez@chromium.org davidben@chromium.org mattm@chromium.org
David: You've had the most opinions about how much code we share vs dupe. My own feeling is that we should be build-restricting this to USE_NSS_CERTS/USE_OPENSSL_CERTS, because it's only intended to drive the UI aspect of Views for selecting certificates. If we're going to keep it, then we either need to massage from OSCertHandles (... which I KNOW you have opinions on ;D) or add _win / _mac implementations (which, uh, gross).

I was going to whip up a CL to do just that, but wasn't sure if you knew of any reason why it'd be useful, if it's only meant for UI-driving.
Build-restricting it SGTM. Yeah, it doesn't seem useful outside of Linux/CrOS.

We also can probably take the USE_OPENSSL_CERTS one out of there. Nothing builds it at all.

Comment 3 by mattm@chromium.org, Apr 29 2016

Where is it being included on non-linux/chromeos platforms?
Or do you just mean that it's not removed from the sources list in gyp/gn? Does listing a .h in sources do anything if nothing includes it?

Comment 4 by mattm@chromium.org, Apr 29 2016

Oh, I guess it's because x509_certificate_model.cc isn't removed.

BTW, https://codereview.chromium.org/1893203005/ is going to clean up some of the USE_OPENSSL_CERTS stuff there.

Comment 5 by eroman@chromium.org, Jun 21 2016

Components: -Internals>Network>SSL Internals>Network>Certificate

Comment 6 by mattm@chromium.org, Mar 16 2018

Cc: -mattm@chromium.org
Owner: mattm@chromium.org
Status: Fixed (was: Untriaged)
This got done during the use_byte_certs work.
https://chromium.googlesource.com/chromium/src/+/381b177ce7cb2df33e1f02c1939d97af7acc2640

Sign in to add a comment