New issue
Advanced search Search tips

Issue 607711 link

Starred by 3 users
Status: Verified
Owner:
rtoy@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 607733
issue 612292


Sign in to add a comment

Track usage count of activity or property in WebAudio

Project Member Reported by hongchan@chromium.org, Apr 28 2016 
As shown in https://codereview.chromium.org/1927313002/, we want to track certain data from the user agent.

WebAudio.AudioContext.maxChannelCount
WebAudio.AudioContext.sampleRate
WebAudio.AudioBuffer.duration (createBuffer, DecodeAudioData)
WebAudio.BiquadFilter.Q
WebAudio.Panner.panningModel

Comment 1 by rtoy@chromium.org, Apr 28 2016 

Tracking of Q is probably only temporary while we try to understand the impact of the new Biquad lowpass and highpass filters. (We also means we probably don't care about Q for the other types.)

Why do we need to keep track of the length of createBuffer?  decodeAudioData makes sense, though.

Comment 2 by rtoy@chromium.org, May 2 2016 

Some other things:

oversample rate of WaveShaper (this has performance implications)
sample rate of AudioBuffer (this has quality implications because we use a very simple linear interpolation for all rate changes)

BiquadFilter.type?  Might be nice to know what is the most common filter type in use, but there isn't really anything actionable we can do with this information.

Comment 3 by rtoy@chromium.org, May 16 2016

Blockedon: 607733

Comment 4 by rtoy@chromium.org, May 16 2016

Blockedon: 612292

Comment 5 by rtoy@chromium.org, May 24 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)

Comment 6 by rtoy@chromium.org, May 26 2016

Blockedon: -612292

Comment 7 by rtoy@chromium.org, May 26 2016

Blockedon: 612292
 Issue 612292  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ceed89c8064f5c835b51c0ea07f259bceaca1d4

commit 8ceed89c8064f5c835b51c0ea07f259bceaca1d4
Author: rtoy <rtoy@chromium.org>
Date: Fri Jun 10 16:59:07 2016

Add UMA histograms for WebAudio.

Histograms are added to keep track of the following properties:

AudioBuffer.numberOfChannels
AudioBuffer.length
AudioBuffer.sampleRate
AudioBuffer.sampleRateRatio (buffer rate divided by context rate)
AudioContext.maxChannelCount
AudioContext.sampleRate
BiquadFilter.type
Panner.panningModel
OfflineAudioContext.channelCount
OfflineAudioContext.length
OfflineAudioContext.sampleRate

BUG= 607711 , 621292
TEST=manually test using chrome://histograms

Review-Url: https://codereview.chromium.org/1978403004
Cr-Commit-Position: refs/heads/master@{#399212}

[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/BiquadProcessor.h
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/platform/audio/Panner.h
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/tools/metrics/histograms/histograms.xml

Comment 9 by rtoy@chromium.org, Jun 14 2016

Status: Verified (was: Started)
Verified that stats are showing up now.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ceed89c8064f5c835b51c0ea07f259bceaca1d4

commit 8ceed89c8064f5c835b51c0ea07f259bceaca1d4
Author: rtoy <rtoy@chromium.org>
Date: Fri Jun 10 16:59:07 2016

Add UMA histograms for WebAudio.

Histograms are added to keep track of the following properties:

AudioBuffer.numberOfChannels
AudioBuffer.length
AudioBuffer.sampleRate
AudioBuffer.sampleRateRatio (buffer rate divided by context rate)
AudioContext.maxChannelCount
AudioContext.sampleRate
BiquadFilter.type
Panner.panningModel
OfflineAudioContext.channelCount
OfflineAudioContext.length
OfflineAudioContext.sampleRate

BUG= 607711 , 621292
TEST=manually test using chrome://histograms

Review-Url: https://codereview.chromium.org/1978403004
Cr-Commit-Position: refs/heads/master@{#399212}

[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/BiquadProcessor.h
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/third_party/WebKit/Source/platform/audio/Panner.h
[modify] https://crrev.com/8ceed89c8064f5c835b51c0ea07f259bceaca1d4/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment