New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607701 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Autoroll Polymer

Project Member Reported by dbeam@chromium.org, Apr 28 2016

Issue description

We should make an automatic roller that runs third_party/polymer/v1_0/reproduce.sh (or accomplishes the same goal) and commits the result if all is well.

third_party/polymer/v1_0/reproduce.sh currently does:
- invokes `bower install` to update all elements listed in third_party/polymer/v1_0/bower.json
- applies chrome-specific patches
- removes files we don't care about (i.e. hero.svg, READMEs)
- runs crisper to make the bower installed stuff CSP compatible (i.e. makes "*-extracted.js" files)
- scrapes <link rel=imports> and generates dependency graph (currently in compiled_resources2.gyp format, likely soon in GN instead)
- vulcanizes dependent UIs (i.e. downloads)

The only thing it probably needs to do more than this is:
- add files to GRD files? (or die if that's required so a human can intervene)
- remove unused elements (i.e. dependencies) or GRD file entries? (same as above: or bail)
- be able to run headlessly/automatedly, maybe strip the fancy unicode/colored output from `bower install`
 
I don't think a full auto-roll is feasible until we have screenshot diffing. It would be great to have a bot doing all of this and running tests, but actually landing Polymer is dangerous if nobody's looking at the UI.

re: bower output, isn't it smart enough to not output color codes when not in a terminal?
Hi - 

Regarding screenshot diffing, I think I maintain the only non-Blink pixel test in Chromium: and it is HARD to get it to work consistently across multiple platforms.

https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/plugins/plugin_power_saver_browsertest.cc&q=PluginPowerSaver&sq=package:chromium&l=368

But probably worth it if other people also think it's worth investigating.
Cc: dbeam@chromium.org
Is this bug still relevant? For quite a while now, we have specified fixed versions of all our dependencies, and when rolling Polymer we only bump up the version of a specific element dependency (or Polymer core itself).

Implementing automatic screenshot diffing sounds not trivial, so realistically I don't see us spending the time to implement and maintain such automated flow. 

Voting to close this bug. Thoughts?

Yes, close. in favor.
Status: WontFix (was: Untriaged)
Ok. No objections so far, I am closing this. Feel free to re-open if there are objections.

Sign in to add a comment