New issue
Advanced search Search tips

Issue 607699 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 594594
issue 604826
issue 607733



Sign in to add a comment

Add names for AudioParams

Project Member Reported by rtoy@chromium.org, Apr 28 2016

Issue description

Currently an AudioParam is basically anonymous.  But it would be really helpful if we gave an AudioParam an (internal) name so we know what the AudioParam is.

And when we print out warnings that an AudioParam is being clamped, it's really nice if the warning mentioned the name of the AudioParam.
 

Comment 1 by rtoy@chromium.org, Apr 28 2016

Components: Blink>WebAudio

Comment 2 by rtoy@chromium.org, Apr 28 2016

Blocking: 607733
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f7829c7596aa617ce042877b27e373991e4e682

commit 0f7829c7596aa617ce042877b27e373991e4e682
Author: rtoy <rtoy@chromium.org>
Date: Mon May 02 23:44:06 2016

Add a name attribute for each AudioParam

AudioParam's are fairly opaque but it's useful to know that an AudioParam belongs to a certain node and the name of the AudioParam itself.  This is especially useful for printing messages related to the AudioParam.

BUG= 607699 
TEST=none

Review-Url: https://codereview.chromium.org/1928163002
Cr-Commit-Position: refs/heads/master@{#391102}

[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp
[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/0f7829c7596aa617ce042877b27e373991e4e682/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp

Comment 4 by rtoy@chromium.org, May 5 2016

Status: Fixed (was: Started)

Sign in to add a comment